From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472A3C282D7 for ; Sun, 10 Feb 2019 09:59:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17762214DA for ; Sun, 10 Feb 2019 09:59:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726127AbfBJJ5a (ORCPT ); Sun, 10 Feb 2019 04:57:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35076 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfBJJ53 (ORCPT ); Sun, 10 Feb 2019 04:57:29 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CBA2C05D41C; Sun, 10 Feb 2019 09:57:29 +0000 (UTC) Received: from localhost (ovpn-204-24.brq.redhat.com [10.40.204.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 767706091C; Sun, 10 Feb 2019 09:57:28 +0000 (UTC) Date: Sun, 10 Feb 2019 10:57:27 +0100 From: Stanislaw Gruszka To: Tom Psyborg Cc: linux-wireless@vger.kernel.org, Randy Oostdyk , Daniel Golle , Felix Fietkau , Mathias Kresin Subject: Re: [PATCH v2 3/3] rt2x00: do not print error when queue is full Message-ID: <20190210095726.GC2913@redhat.com> References: <20181221095938.GA29536@redhat.com> <20181227102535.GA25885@redhat.com> <20190102081934.GA5300@redhat.com> <20190209110259.GA14900@redhat.com> <20190209115628.GA16082@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 10 Feb 2019 09:57:29 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, Feb 09, 2019 at 01:28:32PM +0100, Tom Psyborg wrote: > On 09/02/2019, Stanislaw Gruszka wrote: > > On Sat, Feb 09, 2019 at 12:11:03PM +0100, Tom Psyborg wrote: > >> Can you reproduce interface freeze with this patch if you enable debug > >> options to print all dbg messages? > > > > Haven't tried that, but I expect enabling debug messages will > > cause troubles at hardware where printk make CPU hog. > > > > Stanislaw > > > > Take a look at my comment from 23.01.2019. on this link: > https://bugs.openwrt.org/index.php?do=details&task_id=2018 > There might be a chance dbg printks do not cause problems. I'm sure printk cause problems on some hardware i.e. Wt3020 . There is hypothesis that is because kernel try to emit messages by misconfigured 56k serial line, but who knows. This should be debugged and fixed but I have not idea how to do this. Another issue not related with printk is tx queue hung, when queue is full but we do not get any TX status interrupt. This was mitigated in my previous set that caused throughput regression and should be now fixed by latest RFC/RTF set. But there are other issues, that could cause troubles. Stanislaw