From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B521BC169C4 for ; Mon, 11 Feb 2019 09:31:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82CFB20823 for ; Mon, 11 Feb 2019 09:31:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="M4vuQcWe"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ipOBkeny" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726892AbfBKJbC (ORCPT ); Mon, 11 Feb 2019 04:31:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35762 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbfBKJbC (ORCPT ); Mon, 11 Feb 2019 04:31:02 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 08953605FC; Mon, 11 Feb 2019 09:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549877458; bh=N1+Ejv7War7mgILAIbDgQi9g9ogMm7rrksZit7xv1LY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=M4vuQcWeTqZhkd5LHeUU49ynCAUb5rpmWElaMuhWzHVVxQ+TZfTXkXVX9BlC9IAOJ OYGnLi7qhGUlG5cV8IaZ6a1LZH2ZFgpYa3oEWBVjOPszt4GZ8dS3kLHLTDPxTOzp7g MpaOndOh5TcKnje7vP20lPM+2GyDGcGmUbKR5nUY= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DE8B860908; Mon, 11 Feb 2019 09:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549877456; bh=N1+Ejv7War7mgILAIbDgQi9g9ogMm7rrksZit7xv1LY=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=ipOBkeny5xhMjF9lCweseCymNglgUnC5Rvwc6dXHwFQv1YFNmuF8R1+0/MWfNHhei XD0kL0iUzJxsGojYinTEbDF0m4FZPt4pVDNxe9VOEL1JU5f7/HYi0PL/0W2O0Mrcg+ 1z5WzfHihN9++420Im49cWf3OrQHoWj8eIj0YMJU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DE8B860908 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath10k: add dynamic vlan support From: Kalle Valo In-Reply-To: <1542798288-8946-1-git-send-email-mpubbise@codeaurora.org> References: <1542798288-8946-1-git-send-email-mpubbise@codeaurora.org> To: Manikanta Pubbisetty Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Manikanta Pubbisetty User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190211093058.08953605FC@smtp.codeaurora.org> Date: Mon, 11 Feb 2019 09:30:57 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Manikanta Pubbisetty wrote: > Multicast/broadcast traffic destined for a particular vlan group will > always be encrypted in software. To enable dynamic VLANs, it requires > driver support for sending software encrypted packets. > > In ath10k, sending software encrypted frames is allowed only when we insmod > the driver with cryptmode param set to 1, this configuration disables > hardware crypto and enables RAW mode implicitly. Since, enabling raw > mode has performance impact, this cannot be considered as an ideal > solution for supporting VLANs in the driver. > > As an alternative take, in this approach, cryptographic keys for > unicast traffic (per peer PTKs) and keys for non-vlan group traffic > will be configured in hardware, allowing hardware encryption for unicast > and non-vlan group traffic. Only vlan group traffic will be encrypted in > software and pushed to the target with encap mode set to RAW in the TX > descriptors. > > Not all firmwares can support this type of key configuration(having few > keys installed in hardware and few only in software); for this purpose a > new WMI service flag "WMI_SERVICE_PER_PACKET_SW_ENCRYPT" is introduced to > advertise this support. > > Also, adding the logic required to send sw encrypted frames in raw mode. > > Hardwares Tested : QCA9984, QCA988X > Firmwares Tested : 10.4-3.5.3-00057, 10.2.4-1.0-00042 > > Signed-off-by: Manikanta Pubbisetty > Signed-off-by: Kalle Valo I had to fix some conflicts, please carefully check my resolution in the pending branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=7ae879447535ae1327e78dc614385ff6dd45c2fd Applying: ath10k: add dynamic vlan support Using index info to reconstruct a base tree... M drivers/net/wireless/ath/ath10k/core.h M drivers/net/wireless/ath/ath10k/mac.c M drivers/net/wireless/ath/ath10k/wmi.h Falling back to patching base and 3-way merge... Auto-merging drivers/net/wireless/ath/ath10k/wmi.h CONFLICT (content): Merge conflict in drivers/net/wireless/ath/ath10k/wmi.h Auto-merging drivers/net/wireless/ath/ath10k/mac.c Auto-merging drivers/net/wireless/ath/ath10k/core.h Recorded preimage for 'drivers/net/wireless/ath/ath10k/wmi.h' error: Failed to merge in the changes. Patch failed at 0001 ath10k: add dynamic vlan support -- https://patchwork.kernel.org/patch/10692385/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches