From: Herbert Xu <herbert@gondor.apana.org.au>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: David Miller <davem@davemloft.net>,
johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, j@w1.fi, tgraf@suug.ch,
johannes.berg@intel.com, kbuild-all@01.org
Subject: Re: [PATCH 2/2] mac80211: Free mpath object when rhashtable insertion fails (fwd)
Date: Wed, 13 Feb 2019 21:43:04 +0800 [thread overview]
Message-ID: <20190213134304.po7ccz3fnki3cdoh@gondor.apana.org.au> (raw)
In-Reply-To: <alpine.DEB.2.20.1902131349440.3561@hadrien>
On Wed, Feb 13, 2019 at 01:50:20PM +0100, Julia Lawall wrote:
> Perhaps a return is needed after line 436.
I don't think so. The kfree only occurs in the case where the
hash table insertion fails. While we should only return an error
if both the hash table insertion failed and the error is not due
to an existing entry (EEXIST).
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-02-13 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 12:50 [PATCH 2/2] mac80211: Free mpath object when rhashtable insertion fails (fwd) Julia Lawall
2019-02-13 13:43 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213134304.po7ccz3fnki3cdoh@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=j@w1.fi \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).