archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <>
To: Wei Yongjun <>
Cc: Johannes Berg <>,,
Subject: Re: [PATCH] mac80211: mesh: fix missing unlock on error in table_path_del()
Date: Mon, 18 Feb 2019 18:25:08 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Feb 18, 2019 at 06:52:16AM +0000, Wei Yongjun wrote:
> spin_lock_bh() is used in table_path_del() but rcu_read_unlock()
> is used for unlocking. Fix it by using spin_unlock_bh() instead
> of rcu_read_unlock() in the error handling case.
> Fixes: b4c3fbe63601 ("mac80211: Use linked list instead of rhashtable walk for mesh tables")
> Signed-off-by: Wei Yongjun <>

Acked-by: Herbert Xu <>

Thanks for catching this!
Email: Herbert Xu <>
Home Page:
PGP Key:

      reply	other threads:[~2019-02-18 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18  6:52 [PATCH] mac80211: mesh: fix missing unlock on error in table_path_del() Wei Yongjun
2019-02-18 10:25 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).