From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Laura Abbott <labbott@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: mvm: no need to check return value of debugfs_create functions
Date: Wed, 27 Mar 2019 10:26:00 +0900 [thread overview]
Message-ID: <20190327012600.GA3649@kroah.com> (raw)
In-Reply-To: <03bb68be-8e42-a463-2d57-3be051dc2016@redhat.com>
On Tue, Mar 26, 2019 at 04:55:54PM -0700, Laura Abbott wrote:
> On 1/22/19 7:21 AM, Greg Kroah-Hartman wrote:
> > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c
> > index 33b0af24a537..c52cdc538678 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c
> > @@ -1446,9 +1446,8 @@ static ssize_t iwl_dbgfs_quota_min_read(struct file *file,
> > #define MVM_DEBUGFS_READ_WRITE_FILE_OPS(name, bufsz) \
> > _MVM_DEBUGFS_READ_WRITE_FILE_OPS(name, bufsz, struct ieee80211_vif)
> > #define MVM_DEBUGFS_ADD_FILE_VIF(name, parent, mode) do { \
> > - if (!debugfs_create_file(#name, mode, parent, vif, \
> > - &iwl_dbgfs_##name##_ops)) \
> > - goto err; \
> > + debugfs_create_file(#name, mode, parent, vif, \
> > + &iwl_dbgfs_##name##_ops); \
> > } while (0)
> > MVM_DEBUGFS_READ_FILE_OPS(mac_params);
> > @@ -1483,12 +1482,6 @@ void iwl_mvm_vif_dbgfs_register(struct iwl_mvm *mvm, struct ieee80211_vif *vif)
> > mvmvif->dbgfs_dir = debugfs_create_dir("iwlmvm", dbgfs_dir);
> > - if (!mvmvif->dbgfs_dir) {
> > - IWL_ERR(mvm, "Failed to create debugfs directory under %pd\n",
> > - dbgfs_dir);
> > - return;
> > - }
> > -
> > if (iwlmvm_mod_params.power_scheme != IWL_POWER_SCHEME_CAM &&
> > ((vif->type == NL80211_IFTYPE_STATION && !vif->p2p) ||
> > (vif->type == NL80211_IFTYPE_STATION && vif->p2p)))
> > @@ -1537,12 +1530,6 @@ void iwl_mvm_vif_dbgfs_register(struct iwl_mvm *mvm, struct ieee80211_vif *vif)
> > mvmvif->dbgfs_slink = debugfs_create_symlink(dbgfs_dir->d_name.name,
> > mvm->debugfs_dir, buf);
> > - if (!mvmvif->dbgfs_slink)
> > - IWL_ERR(mvm, "Can't create debugfs symbolic link under %pd\n",
> > - dbgfs_dir);
> > - return;
> > -err:
> > - IWL_ERR(mvm, "Can't create debugfs entity\n");
> > }
>
> Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1691034
> of a crash with 5.0 and the user did a bisect which pointed to ff9fb72bc077
> ("debugfs: return error values, not NULL") because the error checking is
> no longer correct in this driver.
>
> Based on https://patchwork.kernel.org/patch/10865839/, it looks like
> this is supposed to go in for 5.2 but this needs to go in now as
> the error checking is currently broken without it. Can this get queued
> for Linus so we can get it in 5.0 stable?
That's odd, I can't see how the error checking is wrong here. If the
directory is not created, an error will be returned, which should be
able to be handled by debugfs_create_file().
So with this patch does the error go away?
strange,
greg k-h
next prev parent reply other threads:[~2019-03-27 1:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:21 [PATCH] iwlwifi: mvm: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-25 19:30 ` Luciano Coelho
2019-03-26 23:55 ` Laura Abbott
2019-03-27 1:26 ` Greg Kroah-Hartman [this message]
2019-03-27 1:47 ` Laura Abbott
2019-03-27 1:53 ` Greg Kroah-Hartman
2019-03-27 6:35 ` Luca Coelho
2019-03-30 9:22 ` Greg Kroah-Hartman
2019-03-30 9:31 ` [PATCH] iwlwifi: properly check debugfs dentry before using it Greg Kroah-Hartman
2019-04-01 15:39 ` Laura Abbott
2019-04-17 7:02 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327012600.GA3649@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).