From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: "Piotr Figiel" <p.figiel@camlintechnologies.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
linux-wireless@vger.kernel.org,
"Arend van Spriel" <arend.vanspriel@broadcom.com>
Subject: Re: [PATCH] brcmfmac: change the order of things in brcmf_detach()
Date: Wed, 1 May 2019 15:23:45 +0000 (UTC) [thread overview]
Message-ID: <20190501152345.48CF960FEE@smtp.codeaurora.org> (raw)
In-Reply-To: <1556532561-24428-1-git-send-email-arend.vanspriel@broadcom.com>
Arend van Spriel <arend.vanspriel@broadcom.com> wrote:
> When brcmf_detach() from the bus layer upon rmmod we can no longer
> communicate. Hence we will set the bus state to DOWN and cleanup
> the event and protocol layer. The network interfaces need to be
> deleted before brcmf_cfg80211_detach() because the latter does the
> wiphy_unregister() which issues a warning if there are still network
> devices linked to the wiphy instance.
>
> This change solves a null pointer dereference issue which happened
> upon issueing rmmod while there are packets queued in bus protocol
> layer.
>
> Reported-by: Rafał Miłecki <rafal@milecki.pl>
> Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Marked RFC as requested, please resend once this is ready to be applied.
Patch set to RFC.
--
https://patchwork.kernel.org/patch/10922029/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-05-01 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 10:09 [PATCH] brcmfmac: change the order of things in brcmf_detach() Arend van Spriel
2019-04-29 16:31 ` Arend Van Spriel
2019-04-30 8:11 ` Piotr Figiel
2019-04-30 10:10 ` Arend Van Spriel
2019-07-20 16:26 ` Rafał Miłecki
2019-07-20 21:34 ` Arend Van Spriel
2019-05-01 15:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501152345.48CF960FEE@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=p.figiel@camlintechnologies.com \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).