From: <pkshih@realtek.com>
To: <kvalo@codeaurora.org>
Cc: <Larry.Finger@lwfinger.net>, <linux-wireless@vger.kernel.org>,
<colin.king@canonical.com>
Subject: [PATCH 0/4] rtlwifi: 8192de: Fix used uninitialized variables in power tracking
Date: Fri, 10 May 2019 16:03:29 +0800 [thread overview]
Message-ID: <20190510080333.3789-1-pkshih@realtek.com> (raw)
From: Ping-Ke Shih <pkshih@realtek.com>
This issue is found by Coverity and repoerted by Colin Ian King. An array
ofdm_index[3] is never initialized.
In order to fix this issue, I refactor the code to be more readable, and
then I investigate the variable ofdm_index[] should be initialized as
the index corresponding to thermal value programmed in efuse.
The cckswing table in the last patch is used to adjust TX power. When I
check this function, the table is in little-endian order, but compare
with register value in cpu order. Then, fix it as well.
Ping-Ke Shih (4):
rtlwifi: 8192de: Reduce indentation and fix coding style
rtlwifi: 8192de: make tables to be 'static const'
rtlwifi: 8192de: Fix used uninitialized variables in power tracking
rtlwifi: 8192de: use le32 to access cckswing tables
.../wireless/realtek/rtlwifi/rtl8192de/dm.c | 695 +++++++++---------
1 file changed, 330 insertions(+), 365 deletions(-)
--
2.21.0
next reply other threads:[~2019-05-10 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 8:03 pkshih [this message]
2019-05-10 8:03 ` [PATCH 1/4] rtlwifi: 8192de: Reduce indentation and fix coding style pkshih
2019-05-28 12:34 ` Kalle Valo
2019-05-10 8:03 ` [PATCH 2/4] rtlwifi: 8192de: make tables to be 'static const' pkshih
2019-05-10 8:03 ` [PATCH 3/4] rtlwifi: 8192de: Fix used uninitialized variables in power tracking pkshih
2019-05-10 8:03 ` [PATCH 4/4] rtlwifi: 8192de: use le32 to access cckswing tables pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510080333.3789-1-pkshih@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).