From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A823CC072B1 for ; Tue, 28 May 2019 12:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80C082081C for ; Tue, 28 May 2019 12:18:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Rkv7vB+a"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Dm7mPJKp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfE1MSf (ORCPT ); Tue, 28 May 2019 08:18:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56124 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726592AbfE1MSe (ORCPT ); Tue, 28 May 2019 08:18:34 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B45F06087F; Tue, 28 May 2019 12:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559045913; bh=P/xJPgEaFpoP31E3fqQphLr7ltwMwL8lDre1PA+osY4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Rkv7vB+aIjsGcyZ1qv5RydDbPoTcnUSowtTa/dLBn9+JzJzw33tAIvMQitbspoB0G xwj63pT70FPYhXuKo/df95dlOK3EC63O4G3zXEi9XyCAj2peQgINKKc/jczRorGzjd bu84dxsmryLjh8YrwFASAWoB2FKJ+GoNdfrfg38Q= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2B9A6601D4; Tue, 28 May 2019 12:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559045912; bh=P/xJPgEaFpoP31E3fqQphLr7ltwMwL8lDre1PA+osY4=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=Dm7mPJKpTsMbO9PbWdABRBzre4eVfMccKtNNceUaRX4rYi7Ri3Cg21sBewXc0xTas GMK+s5+0l9hsRUg9GtpSsR9rzKTn8YQK0DEj3rpiue8vMjBW9JIqjVd/WIMKLRo46Q 5WYrIU2mhucPnTTC2+1oBRhzvxCxCUB8F+4T4ATk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2B9A6601D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 From: Kalle Valo In-Reply-To: <20190517225420.176893-2-dianders@chromium.org> References: <20190517225420.176893-2-dianders@chromium.org> To: Douglas Anderson Cc: Ulf Hansson , Adrian Hunter , Arend van Spriel , linux-rockchip@lists.infradead.org, Double Lo , briannorris@chromium.org, Madhan Mohan R , mka@chromium.org, Wright Feng , Chi-Hsien Lin , Douglas Anderson , brcm80211-dev-list.pdl@broadcom.com, Franky Lin , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Madhan Mohan R , Hante Meuleman , Naveen Gupta , brcm80211-dev-list@cypress.com, YueHaibing , "David S. Miller" User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190528121833.B45F06087F@smtp.codeaurora.org> Date: Tue, 28 May 2019 12:18:33 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Douglas Anderson wrote: > In commit 29f6589140a1 ("brcmfmac: disable command decode in > sdio_aos") we disabled something called "command decode in sdio_aos" > for a whole bunch of Broadcom SDIO WiFi parts. > > After that patch landed I find that my kernel log on > rk3288-veyron-minnie and rk3288-veyron-speedy is filled with: > brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 > > This seems to happen every time the Broadcom WiFi transitions out of > sleep mode. Reverting the part of the commit that affects the WiFi on > my boards fixes the problem for me, so that's what this patch does. > > Note that, in general, the justification in the original commit seemed > a little weak. It looked like someone was testing on a SD card > controller that would sometimes die if there were CRC errors on the > bus. This used to happen back in early days of dw_mmc (the controller > on my boards), but we fixed it. Disabling a feature on all boards > just because one SD card controller is broken seems bad. ...so > instead of just this patch possibly the right thing to do is to fully > revert the original commit. > > Fixes: 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") > Signed-off-by: Douglas Anderson I don't see patch 2 in patchwork and I assume discussion continues. Please resend if/when I need to apply something. 2 patches set to Changes Requested. 10948785 [1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 10948777 [3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail -- https://patchwork.kernel.org/patch/10948785/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches