From: Kalle Valo <kvalo@codeaurora.org>
To: Miaoqing Pan <miaoqing@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Miaoqing Pan <miaoqing@codeaurora.org>
Subject: Re: [PATCH v2] ath10k: fix fw crash by moving chip reset after napi disabled
Date: Tue, 25 Jun 2019 12:59:50 +0000 (UTC) [thread overview]
Message-ID: <20190625125950.E2E4B601E7@smtp.codeaurora.org> (raw)
In-Reply-To: <1558667782-10998-1-git-send-email-miaoqing@codeaurora.org>
Miaoqing Pan <miaoqing@codeaurora.org> wrote:
> On SMP platform, when continuously running wifi up/down, the napi
> poll can be scheduled during chip reset, which will call
> ath10k_pci_has_fw_crashed() to check the fw status. But in the reset
> period, the value from FW_INDICATOR_ADDRESS register will return
> 0xdeadbeef, which also be treated as fw crash. Fix the issue by
> moving chip reset after napi disabled.
>
> ath10k_pci 0000:01:00.0: firmware crashed! (guid 73b30611-5b1e-4bdd-90b4-64c81eb947b6)
> ath10k_pci 0000:01:00.0: qca9984/qca9994 hw1.0 target 0x01000000 chip_id 0x00000000 sub 168c:cafe
> ath10k_pci 0000:01:00.0: htt-ver 2.2 wmi-op 6 htt-op 4 cal otp max-sta 512 raw 0 hwcrypto 1
> ath10k_pci 0000:01:00.0: failed to get memcpy hi address for firmware address 4: -16
> ath10k_pci 0000:01:00.0: failed to read firmware dump area: -16
> ath10k_pci 0000:01:00.0: Copy Engine register dump:
> ath10k_pci 0000:01:00.0: [00]: 0x0004a000 0 0 0 0
> ath10k_pci 0000:01:00.0: [01]: 0x0004a400 0 0 0 0
> ath10k_pci 0000:01:00.0: [02]: 0x0004a800 0 0 0 0
> ath10k_pci 0000:01:00.0: [03]: 0x0004ac00 0 0 0 0
> ath10k_pci 0000:01:00.0: [04]: 0x0004b000 0 0 0 0
> ath10k_pci 0000:01:00.0: [05]: 0x0004b400 0 0 0 0
> ath10k_pci 0000:01:00.0: [06]: 0x0004b800 0 0 0 0
> ath10k_pci 0000:01:00.0: [07]: 0x0004bc00 1 0 1 0
> ath10k_pci 0000:01:00.0: [08]: 0x0004c000 0 0 0 0
> ath10k_pci 0000:01:00.0: [09]: 0x0004c400 0 0 0 0
> ath10k_pci 0000:01:00.0: [10]: 0x0004c800 0 0 0 0
> ath10k_pci 0000:01:00.0: [11]: 0x0004cc00 0 0 0 0
>
> Tested HW: QCA9984,QCA9887,WCN3990
>
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
08d80e4cd27b ath10k: fix fw crash by moving chip reset after napi disabled
--
https://patchwork.kernel.org/patch/10959057/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-06-25 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 3:16 [PATCH v2] ath10k: fix fw crash by moving chip reset after napi disabled Miaoqing Pan
2019-06-25 12:59 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625125950.E2E4B601E7@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).