From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: <linux-wireless@vger.kernel.org>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [RFC PATCH] rtw88: use txpwr_lmt_cfg_pair struct, not arrays
Date: Wed, 24 Jul 2019 11:23:04 +0000 (UTC) [thread overview]
Message-ID: <20190724112304.7DDF960909@smtp.codeaurora.org> (raw)
In-Reply-To: <20190713013232.215138-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> We're just trusting that these tables are of the right dimensions, when
> we could do better by just using the struct directly. Let's expose the
> struct txpwr_lmt_cfg_pair instead.
>
> The table changes were made by using some Vim macros, so that should
> help prevent any translation mistakes along the way.
>
> Remaining work: get the 'void *data' out of the generic struct
> rtw_table; all of these tables really deserve to be their own data
> structure, with proper type fields.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
To me this looks like a clear improvement and I'm inclined to apply it. Tony,
what do you think?
--
https://patchwork.kernel.org/patch/11042813/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-07-24 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 1:32 [RFC PATCH] rtw88: use txpwr_lmt_cfg_pair struct, not arrays Brian Norris
2019-07-24 11:23 ` Kalle Valo [this message]
2019-07-25 2:26 ` Tony Chuang
2019-07-25 5:59 ` Kalle Valo
2019-07-25 8:55 ` Tony Chuang
2019-08-06 12:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724112304.7DDF960909@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).