From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F62C7618B for ; Wed, 24 Jul 2019 11:23:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B4B72190F for ; Wed, 24 Jul 2019 11:23:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="jUEHjMqb"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="C+earYBO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727137AbfGXLXF (ORCPT ); Wed, 24 Jul 2019 07:23:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34848 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfGXLXF (ORCPT ); Wed, 24 Jul 2019 07:23:05 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7DDF960909; Wed, 24 Jul 2019 11:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563967384; bh=7xvzidbz6f6PnQwcm5w5sgSgmFxlWi2HS9D/bvmliDo=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=jUEHjMqb9FoZlOvhOz5PGhCIdz1HAHaJZhX14MvsRxB4EL499pqVaPuZMNfHimw4/ detqbf5L4j3nacF/639QsvHwNiM9xgJHlXoYah96ZlXFskq+petB2A2emWVcrjvPFM 2yz798/KKuhJM+/PKVtVcbV96n+zOcTkDNbNmv7M= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F1FDC60734; Wed, 24 Jul 2019 11:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563967383; bh=7xvzidbz6f6PnQwcm5w5sgSgmFxlWi2HS9D/bvmliDo=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=C+earYBORtatRP+1I/m2VclvOY/79qXhX46bC3sX2yV7eQSoontpGVrAC3PbLUAXs G0b0CMVDjtaC1ztt1R7UiC/dwDXEMK8+BtekOxr4uxYEWzCYxXhvZhK2XB9embQ4jZ uhO63Pa35PIFvwHP6Yfb7OmZvsb7Xo+owR6vmq2Y= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F1FDC60734 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [RFC PATCH] rtw88: use txpwr_lmt_cfg_pair struct, not arrays From: Kalle Valo In-Reply-To: <20190713013232.215138-1-briannorris@chromium.org> References: <20190713013232.215138-1-briannorris@chromium.org> To: Brian Norris Cc: , Yan-Hsuan Chuang , Brian Norris User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190724112304.7DDF960909@smtp.codeaurora.org> Date: Wed, 24 Jul 2019 11:23:04 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Brian Norris wrote: > We're just trusting that these tables are of the right dimensions, when > we could do better by just using the struct directly. Let's expose the > struct txpwr_lmt_cfg_pair instead. > > The table changes were made by using some Vim macros, so that should > help prevent any translation mistakes along the way. > > Remaining work: get the 'void *data' out of the generic struct > rtw_table; all of these tables really deserve to be their own data > structure, with proper type fields. > > Signed-off-by: Brian Norris To me this looks like a clear improvement and I'm inclined to apply it. Tony, what do you think? -- https://patchwork.kernel.org/patch/11042813/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches