From: Greg KH <gregkh@linuxfoundation.org>
To: Adham.Abozaeid@microchip.com
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
johannes@sipsolutions.net, Ajay.Kathat@microchip.com
Subject: Re: [PATCH] staging: wilc1000: merge drv_handle and operation_mode wids
Date: Thu, 1 Aug 2019 18:41:55 +0200 [thread overview]
Message-ID: <20190801164155.GA14688@kroah.com> (raw)
In-Reply-To: <20190731205245.6590-1-adham.abozaeid@microchip.com>
On Wed, Jul 31, 2019 at 08:58:19PM +0000, Adham.Abozaeid@microchip.com wrote:
> From: Adham Abozaeid <adham.abozaeid@microchip.com>
>
> wilc_set_wfi_drv_handler and wilc_set_operation_mode sends the same
> parameters to the FW, so it's better to combine them together.
>
> Kept wilc_set_wfi_drv_handler implementation since it sends all the
> required parameters, and renamed it to wilc_set_operation_mode to be
> more descriptive.
>
> Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com>
> ---
> drivers/staging/wilc1000/wilc_hif.c | 29 ++-----------------
> drivers/staging/wilc1000/wilc_hif.h | 5 ++--
> drivers/staging/wilc1000/wilc_netdev.c | 6 ++--
> .../staging/wilc1000/wilc_wfi_cfgoperations.c | 24 +++++++--------
> drivers/staging/wilc1000/wilc_wlan_if.h | 3 +-
> 5 files changed, 20 insertions(+), 47 deletions(-)
This patch causes the following build error:
drivers/staging/wilc1000/wilc_hif.c: In function wilc_deinit:
drivers/staging/wilc1000/wilc_hif.c:1610:2: error: implicit declaration of function wilc_set_wfi_drv_handler [-Werror=implicit-function-declaration]
1610 | wilc_set_wfi_drv_handler(vif, 0, 0, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~
Always test build your patches...
next prev parent reply other threads:[~2019-08-01 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 20:58 [PATCH] staging: wilc1000: merge drv_handle and operation_mode wids Adham.Abozaeid
2019-08-01 16:41 ` Greg KH [this message]
2019-08-01 19:14 ` Adham.Abozaeid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801164155.GA14688@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Adham.Abozaeid@microchip.com \
--cc=Ajay.Kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).