From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ACFDC31E40 for ; Tue, 6 Aug 2019 12:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DDA6206A2 for ; Tue, 6 Aug 2019 12:25:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="QejDs9ks"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="oGQzhpTA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729898AbfHFMZT (ORCPT ); Tue, 6 Aug 2019 08:25:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54386 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfHFMZT (ORCPT ); Tue, 6 Aug 2019 08:25:19 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 01947608CC; Tue, 6 Aug 2019 12:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565094319; bh=ca1LOVDmRVvP70xkzyWoS5J/M4KpZeq3R2plRp/fxxY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=QejDs9ksjnVzZcbG4qdpVIKR8VL/+dTLxdf9m079lGt/8ttZdb3JG/1CVOUwkjHWo Unrw8hto5FTD2WY6eut43sgiQtcDFeyik5yM+/WF6KMap+Kkd9Xz7T2BNauYBvJV9b q2XC+iXCh2Mn1ezVPI6zaMfe/g442fg0U+Lbgc78= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8958B60452; Tue, 6 Aug 2019 12:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565094318; bh=ca1LOVDmRVvP70xkzyWoS5J/M4KpZeq3R2plRp/fxxY=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=oGQzhpTAnWOkcNiJh6L7AEk+Rdd1FmCMMndk6IAunv0wzC9YB16Ku3oMRWZowWrfe 7PUodzv3LgPhynggcrW/hbCjW1ISzvbLs4+1ltKOntLGCZMnoT/NwlWXNwZ/5g2Q/K fYX398HyNQgzYZi4p48wGeI2gOedu+5Ntnonb6zU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8958B60452 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [RFC PATCH] rtw88: use txpwr_lmt_cfg_pair struct, not arrays From: Kalle Valo In-Reply-To: <20190713013232.215138-1-briannorris@chromium.org> References: <20190713013232.215138-1-briannorris@chromium.org> To: Brian Norris Cc: , Yan-Hsuan Chuang , Brian Norris User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190806122519.01947608CC@smtp.codeaurora.org> Date: Tue, 6 Aug 2019 12:25:19 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Brian Norris wrote: > We're just trusting that these tables are of the right dimensions, when > we could do better by just using the struct directly. Let's expose the > struct txpwr_lmt_cfg_pair instead. > > The table changes were made by using some Vim macros, so that should > help prevent any translation mistakes along the way. > > Remaining work: get the 'void *data' out of the generic struct > rtw_table; all of these tables really deserve to be their own data > structure, with proper type fields. > > Signed-off-by: Brian Norris Patch applied to wireless-drivers-next.git, thanks. 3457f86da60d rtw88: use txpwr_lmt_cfg_pair struct, not arrays -- https://patchwork.kernel.org/patch/11042813/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches