From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E1CC433FF for ; Tue, 6 Aug 2019 12:44:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8F2E20B1F for ; Tue, 6 Aug 2019 12:44:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lo8RqwlQ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="RGc2qDdn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731053AbfHFMoK (ORCPT ); Tue, 6 Aug 2019 08:44:10 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36210 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbfHFMoJ (ORCPT ); Tue, 6 Aug 2019 08:44:09 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C8A496038E; Tue, 6 Aug 2019 12:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565095448; bh=HAu7TsW0Iie3+5DrXvxcWN8iTVu6QAEL2sslX8UhT5k=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=lo8RqwlQE5Xi0nIj0VPa0UZ39EZ7qOVHWA4qL+17ZIPV1oi0tasFEzwjKhAVr9W7P AG9dsCg3IgIHL6rHGAwfXvdeb5zl01aSrEQIT0FP/jh0M3UGMn4efvjXoqdAfpAYQt JCUurAAd7ArIuFYWypYT2GzIaNQ6d73JrmziUF1c= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3EDB960867; Tue, 6 Aug 2019 12:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565095448; bh=HAu7TsW0Iie3+5DrXvxcWN8iTVu6QAEL2sslX8UhT5k=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=RGc2qDdndYOY+tJhAqFvfznPJbOUNFNJLTIZtdJTACWHYqLt5heBo8w2IDXYmogtZ ibyCZrRLFye6jgs4SmRc+JJANJa3UFjI9WHDYJSvrSydrjfrXc5nEqubhN3V0Z4dZB XP1L/YwCUcHLqvAzcfurviqNbZP4JdTD1rZ9eHFs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3EDB960867 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH V2] b43legacy: Remove pointless cond_resched() wrapper From: Kalle Valo In-Reply-To: References: To: Thomas Gleixner Cc: linux-wireless@vger.kernel.org, Larry Finger , b43-dev@lists.infradead.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190806124408.C8A496038E@smtp.codeaurora.org> Date: Tue, 6 Aug 2019 12:44:08 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Thomas Gleixner wrote: > cond_resched() can be used unconditionally. If CONFIG_PREEMPT is set, it > becomes a NOP scheduler wise. > > Also the B43_BUG_ON() in that wrapper is a homebrewn variant of > __might_sleep() which is part of cond_resched() already. > > Remove the cruft and invoke cond_resched() directly. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Larry Finger > Tested-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. 6004cf298a41 b43legacy: Remove pointless cond_resched() wrapper -- https://patchwork.kernel.org/patch/11073225/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches