* [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor
@ 2019-08-12 19:27 Larry Finger
2019-08-20 14:08 ` Kalle Valo
2019-09-03 13:28 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Larry Finger @ 2019-08-12 19:27 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, pkshih, Larry Finger
In the process of converting the bit manipulation macros were converted
to use GENMASK(), the compiler reported a value too big for the field.
The offending statement was trying to write 0x100 into a 5-bit field.
An accompaning comment says to set bit 3, thus the code is changed
appropriately.
This error has been in the driver since its initial submission.
Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
index 0020adc004a5..9b5c7ec6b6f7 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
@@ -611,7 +611,7 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 *pdesc,
SET_TX_DESC_NAV_USE_HDR(pdesc, 1);
} else {
SET_TX_DESC_HWSEQ_EN(pdesc, 1); /* Hw set sequence number */
- SET_TX_DESC_PKT_ID(pdesc, 0x100); /* set bit3 to 1. */
+ SET_TX_DESC_PKT_ID(pdesc, BIT(3)); /* set bit3 to 1. */
}
SET_TX_DESC_USE_RATE(pdesc, 1); /* use data rate which is set by Sw */
SET_TX_DESC_OWN(pdesc, 1);
--
2.22.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor
2019-08-12 19:27 [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor Larry Finger
@ 2019-08-20 14:08 ` Kalle Valo
2019-08-20 15:36 ` Larry Finger
2019-09-03 13:28 ` Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2019-08-20 14:08 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih, Larry Finger
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In the process of converting the bit manipulation macros were converted
> to use GENMASK(), the compiler reported a value too big for the field.
> The offending statement was trying to write 0x100 into a 5-bit field.
> An accompaning comment says to set bit 3, thus the code is changed
> appropriately.
>
> This error has been in the driver since its initial submission.
>
> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
I only see patch 5 on patchwork, what happened to patches 1-4?
--
https://patchwork.kernel.org/patch/11090677/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor
2019-08-20 14:08 ` Kalle Valo
@ 2019-08-20 15:36 ` Larry Finger
2019-08-20 15:52 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2019-08-20 15:36 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, pkshih
On 8/20/19 9:08 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
>> In the process of converting the bit manipulation macros were converted
>> to use GENMASK(), the compiler reported a value too big for the field.
>> The offending statement was trying to write 0x100 into a 5-bit field.
>> An accompaning comment says to set bit 3, thus the code is changed
>> appropriately.
>>
>> This error has been in the driver since its initial submission.
>>
>> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> I only see patch 5 on patchwork, what happened to patches 1-4?
I pulled them at the last minute, but forgot to rename the subject. Please apply
that fix alone. The others will follow when I get time; however, they are code
improvements. Only this one was a code fix.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor
2019-08-20 15:36 ` Larry Finger
@ 2019-08-20 15:52 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2019-08-20 15:52 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 8/20/19 9:08 AM, Kalle Valo wrote:
>> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>>> In the process of converting the bit manipulation macros were converted
>>> to use GENMASK(), the compiler reported a value too big for the field.
>>> The offending statement was trying to write 0x100 into a 5-bit field.
>>> An accompaning comment says to set bit 3, thus the code is changed
>>> appropriately.
>>>
>>> This error has been in the driver since its initial submission.
>>>
>>> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>
>> I only see patch 5 on patchwork, what happened to patches 1-4?
>
> I pulled them at the last minute, but forgot to rename the subject.
> Please apply that fix alone. The others will follow when I get time;
> however, they are code improvements. Only this one was a code fix.
Ok, I was just worried if patchwork had lost of them somehow.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor
2019-08-12 19:27 [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor Larry Finger
2019-08-20 14:08 ` Kalle Valo
@ 2019-09-03 13:28 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2019-09-03 13:28 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, pkshih, Larry Finger
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In the process of converting the bit manipulation macros were converted
> to use GENMASK(), the compiler reported a value too big for the field.
> The offending statement was trying to write 0x100 into a 5-bit field.
> An accompaning comment says to set bit 3, thus the code is changed
> appropriately.
>
> This error has been in the driver since its initial submission.
>
> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers-next.git, thanks.
01bb31de5262 rtlwifi: rtl8192cu: Fix value set in descriptor
--
https://patchwork.kernel.org/patch/11090677/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-03 13:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12 19:27 [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor Larry Finger
2019-08-20 14:08 ` Kalle Valo
2019-08-20 15:36 ` Larry Finger
2019-08-20 15:52 ` Kalle Valo
2019-09-03 13:28 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).