linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>,
	<sgruszka@redhat.com>
Subject: Re: [PATCH 1/8] rtw88: 8822c: update PHY parameter to v38
Date: Fri,  6 Sep 2019 14:06:03 +0000 (UTC)	[thread overview]
Message-ID: <20190906140603.2BADE60770@smtp.codeaurora.org> (raw)
In-Reply-To: <1565174405-2689-2-git-send-email-yhchuang@realtek.com>

<yhchuang@realtek.com> wrote:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> Update PHY hardware parameters to v38.
> 
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>

New warnings:

drivers/net/wireless/realtek/rtw88/phy.c: In function 'rtw_phy_get_dis_dpd_by_rate_diff':
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1557:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(6M);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1558:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(9M);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1558:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(9M);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1559:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(MCS0);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1559:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(MCS0);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1560:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(MCS1);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1560:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(MCS1);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1561:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(MCS8);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1561:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(MCS8);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1562:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(MCS9);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1562:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(MCS9);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1563:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(VHT1SS_MCS0);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1563:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(VHT1SS_MCS0);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1564:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(VHT1SS_MCS1);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1564:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(VHT1SS_MCS1);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1565:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(VHT2SS_MCS0);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1553:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (DIS_DPD_RATE ## _rate & chip->dpd_ratemask)  \
      ^
drivers/net/wireless/realtek/rtw88/phy.c:1565:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(VHT2SS_MCS0);
  ^~~~~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/phy.c:1552:2: note: here
  case DESC_RATE ## _rate:     \
  ^~~~
drivers/net/wireless/realtek/rtw88/phy.c:1566:2: note: in expansion of macro 'RTW_DPD_RATE_CHECK'
  RTW_DPD_RATE_CHECK(VHT2SS_MCS1);
  ^~~~~~~~~~~~~~~~~~

8 patches set to Changes Requested.

11081855 [1/8] rtw88: 8822c: update PHY parameter to v38
11081853 [2/8] rtw88: 8822c: update pwr_seq to v13
11081843 [3/8] rtw88: 8822c: Enable interrupt migration
11081851 [PATCH 4/8] rtw88: 8822c: add FW IQK support
11081857 [5/8] rtw88: 8822c: add SW DPK support
11081845 [6/8] rtw88: move IQK/DPK into phy_calibration
11081849 [7/8] rtw88: add dynamic cck pd mechanism
11081847 [8/8] rtw88: allows to receive AMSDU in AMPDU

-- 
https://patchwork.kernel.org/patch/11081855/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


  reply	other threads:[~2019-09-06 14:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 10:39 [PATCH 0/8] rtw88: enhance and stabilize T-Put performance yhchuang
2019-08-07 10:39 ` [PATCH 1/8] rtw88: 8822c: update PHY parameter to v38 yhchuang
2019-09-06 14:06   ` Kalle Valo [this message]
2019-08-07 10:39 ` [PATCH 2/8] rtw88: 8822c: update pwr_seq to v13 yhchuang
2019-08-07 10:40 ` [PATCH 3/8] rtw88: 8822c: Enable interrupt migration yhchuang
2019-08-07 10:40 ` [PATCH 4/8] rtw88: 8822c: add FW IQK support yhchuang
2019-09-03 12:53   ` Kalle Valo
2019-09-04  2:31     ` Tony Chuang
2019-09-06 14:13       ` Kalle Valo
2019-08-07 10:40 ` [PATCH 5/8] rtw88: 8822c: add SW DPK support yhchuang
2019-08-07 10:40 ` [PATCH 6/8] rtw88: move IQK/DPK into phy_calibration yhchuang
2019-08-07 10:40 ` [PATCH 7/8] rtw88: add dynamic cck pd mechanism yhchuang
2019-08-07 10:40 ` [PATCH 8/8] rtw88: allows to receive AMSDU in AMPDU yhchuang
2019-09-02  9:06 ` [PATCH 0/8] rtw88: enhance and stabilize T-Put performance Tony Chuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906140603.2BADE60770@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=briannorris@chromium.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).