From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F5DC43331 for ; Fri, 6 Sep 2019 14:10:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDA442070C for ; Fri, 6 Sep 2019 14:10:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="PB/QzTq4"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="hnssT2yw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404531AbfIFOKy (ORCPT ); Fri, 6 Sep 2019 10:10:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45000 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728978AbfIFOKx (ORCPT ); Fri, 6 Sep 2019 10:10:53 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0C1346115A; Fri, 6 Sep 2019 14:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567779053; bh=pZrUubcES+XghCJoDqpsjKdHbbqNAWcea7tZv+3cJls=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=PB/QzTq4vvnoX6Ec08VgumK/NnLndObCoK/SP7fODDhk+sZVv003IEVCVWyQTqbUE KtLs8oPTj7k/14GeD/m0c74sF5PzLdGUTldcWfOBaLn1n3bzAwMmH6iyNmnHF98wVd 36ywf3ytQD3nhK8INWpvLMWiy3zWjjBf++Y/xPO0= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 88E1760770; Fri, 6 Sep 2019 14:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567779052; bh=pZrUubcES+XghCJoDqpsjKdHbbqNAWcea7tZv+3cJls=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=hnssT2ywZ8Zee38Uk+I6TrEaVUE0ioMAujTXsXuBYJqM9159Z1NtNWJm75iZbz5pD TpQ5lrNxY8cQPSndyXx/QPyqy3xTNduh1DY6HWnpEnjPFpdfQ76YclZIrb4qO6ZnGV WP4klE3Sg4hK+fhOScfp8Qvci7auySvHpUdTED/8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 88E1760770 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: fix seq_file memory leak From: Kalle Valo In-Reply-To: <20190904141601.186107-1-weiyongjun1@huawei.com> References: <20190904141601.186107-1-weiyongjun1@huawei.com> To: Wei Yongjun Cc: Yan-Hsuan Chuang , Wei Yongjun , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190906141053.0C1346115A@smtp.codeaurora.org> Date: Fri, 6 Sep 2019 14:10:53 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wei Yongjun wrote: > When using single_open(), single_release() should be used instead > of seq_release(), otherwise there is a memory leak. > > This is detected by Coccinelle semantic patch. > > Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver") > Signed-off-by: Wei Yongjun Patch applied to wireless-drivers-next.git, thanks. eb9affaeff70 rtw88: fix seq_file memory leak -- https://patchwork.kernel.org/patch/11130355/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches