From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA6D0C4740A for ; Mon, 9 Sep 2019 18:33:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FA53218AF for ; Mon, 9 Sep 2019 18:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731762AbfIISdk (ORCPT ); Mon, 9 Sep 2019 14:33:40 -0400 Received: from bues.ch ([80.190.117.144]:35222 "EHLO bues.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727014AbfIISdk (ORCPT ); Mon, 9 Sep 2019 14:33:40 -0400 X-Greylist: delayed 2442 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 Sep 2019 14:33:38 EDT Received: by bues.ch with esmtpsa (Exim 4.92) (envelope-from ) id 1i7NqP-0005NC-Vv; Mon, 09 Sep 2019 19:52:54 +0200 Date: Mon, 9 Sep 2019 19:53:12 +0200 From: Michael =?UTF-8?B?QsO8c2No?= To: Kalle Valo Cc: Colin King , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller Message-ID: <20190909195312.1873c0f7@wiggum> In-Reply-To: <20190906154053.32218-1-colin.king@canonical.com> References: <20190906154053.32218-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Gh5rJFI_YvQsdaAQbg3kPxs"; protocol="application/pgp-signature"; micalg=pgp-sha512 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --Sig_/Gh5rJFI_YvQsdaAQbg3kPxs Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 6 Sep 2019 16:40:53 +0100 Colin King wrote: > diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c > index da2d2ab8104d..7c3ae52f2b15 100644 > --- a/drivers/ssb/pci.c > +++ b/drivers/ssb/pci.c > @@ -595,7 +595,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, c= onst u16 *in) > { > int i; > u16 o; > - u16 pwr_info_offset[] =3D { > + static const u16 pwr_info_offset[] =3D { > SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1, > SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3 > }; Thanks for your contribution. This change makes sense. Kalle, can you please take it? Acked-by: Michael B=C3=BCsch --=20 Michael --Sig_/Gh5rJFI_YvQsdaAQbg3kPxs Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAl12kYgACgkQ9TK+HZCN iw4dkg//RkZq55Col2WsmizgjsdDYipwL9loeVjtw64YjtT2ZVcwSzQfooPf253D BKLbB6AbBNc3oniPuicHJZGxNX5ppfO6teIcHvzd1gtlNIDyRRU+dFA4DoqskKlK 9n7JWAWmXxLhpw8121mQmtV5MYbHJRR6fhemrDJPtKRwJLfcZSLF5ENUu3VCifw2 /G5PqA7Lsu7llxd6Cl5uz3fD4wX3o9LRaVsF/QZvmGoV6FdqUgf/cRGXtOGYzCQ4 2DVxrykaS8VTWqvbJQ1LIlDv1u2cGxIWlvAlI3t40CCR6md914C9abWj+o48wDPd DE/kCQeJy6uHqcc3yYTp888a4tnWnsAovNySHNwefvRCbcU3q5fKbluX5Zth9r1u 6JqQoAglH3wNUaUJ1nXuASWz9l7J9IkJakzHZzzxy1cQ5uvZXeP5T1FPbrlKOSJX cvICP9T79dtDR9XmjRd5jKLpXCHNO0ZVgo6PfxoRJtxD60cwLtKMKlNjP+9Hto23 sKnQ6wuEhIluxun1x4pb73+8WLzL8f9u9nlh/HVSvnh39QlarMUMAbWXAH/J182J O/65KfRCcUkoBxMIvwtnCckj08NmrHrS5DVIp2YaMbzjlLpKvFSCxf+65pB2CREt EeG3/vOb9ElEjrJdWXy+BB4rOCLoxk4Ks07DZXbrq0FJPjg5DbI= =/ENb -----END PGP SIGNATURE----- --Sig_/Gh5rJFI_YvQsdaAQbg3kPxs--