From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: simplify TX aggregation start
Date: Wed, 2 Oct 2019 11:08:49 +0200 [thread overview]
Message-ID: <20191002090849.GA2943@redhat.com> (raw)
In-Reply-To: <1569960387-I152912660131cbab2e5d80b4218238c20f8a06e5@changeid>
On Tue, Oct 01, 2019 at 10:06:29PM +0200, Johannes Berg wrote:
> index f1cdcd61c54a..b74e758cce09 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -10489,7 +10489,7 @@ int rt2800_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
> */
> break;
> case IEEE80211_AMPDU_TX_START:
> - ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid);
> + ret = IEEE80211_AMPDU_TX_START_IMMEDIATE;
> break;
> case IEEE80211_AMPDU_TX_STOP_CONT:
> case IEEE80211_AMPDU_TX_STOP_FLUSH:
<snip>
> +#define IEEE80211_AMPDU_TX_START_IMMEDIATE 1
> +
> /**
On rt2x00 we already return 1 for case we do not have free HW WCID
number for a remote station.
if (sta_priv->wcid > WCID_END)
return 1;
So we should change that to some other error code i.e. -ENOSPC.
Stanislaw
next prev parent reply other threads:[~2019-10-02 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 20:06 [PATCH] mac80211: simplify TX aggregation start Johannes Berg
2019-10-02 4:25 ` kbuild test robot
2019-10-02 9:08 ` Stanislaw Gruszka [this message]
2019-10-02 9:09 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002090849.GA2943@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).