* [PATCH] ath10k: Fix an && vs || typo
@ 2019-10-07 8:50 Dan Carpenter
2019-10-08 15:42 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-10-07 8:50 UTC (permalink / raw)
To: Kalle Valo, Govind Singh; +Cc: ath10k, linux-wireless, kernel-janitors
The kernel will Oops later in the function if either of these pointers
is NULL so clearly || was intended instead of &&.
Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/ath/ath10k/snoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index cd22c8654aa9..16177497bba7 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -1400,7 +1400,7 @@ static void ath10k_msa_dump_memory(struct ath10k *ar,
size_t buf_len;
u8 *buf;
- if (!crash_data && !crash_data->ramdump_buf)
+ if (!crash_data || !crash_data->ramdump_buf)
return;
mem_layout = ath10k_coredump_get_mem_layout(ar);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath10k: Fix an && vs || typo
2019-10-07 8:50 [PATCH] ath10k: Fix an && vs || typo Dan Carpenter
@ 2019-10-08 15:42 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-10-08 15:42 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Govind Singh, ath10k, linux-wireless, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The kernel will Oops later in the function if either of these pointers
> is NULL so clearly || was intended instead of &&.
>
> Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Sorry, Colin was faster :)
https://patchwork.kernel.org/patch/11174955/
Patch set to Rejected.
--
https://patchwork.kernel.org/patch/11176991/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-08 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07 8:50 [PATCH] ath10k: Fix an && vs || typo Dan Carpenter
2019-10-08 15:42 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).