Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] rtw88: Fix an error message
@ 2019-10-07  8:48 Dan Carpenter
  2019-10-09  8:27 ` Kalle Valo
  0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2019-10-07  8:48 UTC (permalink / raw)
  To: Yan-Hsuan Chuang; +Cc: Kalle Valo, linux-wireless, kernel-janitors

The WARN_ON() macro doesn't take an error message, the argument is a
condition so this won't display the warning message.

Fixes: 27e117e4b01b ("rtw88: add deep power save support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/wireless/realtek/rtw88/ps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/ps.c b/drivers/net/wireless/realtek/rtw88/ps.c
index 83db6cf6a219..228309b411ec 100644
--- a/drivers/net/wireless/realtek/rtw88/ps.c
+++ b/drivers/net/wireless/realtek/rtw88/ps.c
@@ -108,7 +108,7 @@ void rtw_power_mode_change(struct rtw_dev *rtwdev, bool enter)
 		 * read/write. It should be treated as fatal error and
 		 * requires an entire analysis about the firmware/hardware
 		 */
-		WARN_ON("Hardware power state locked\n");
+		WARN(1, "Hardware power state locked\n");
 	}
 }
 EXPORT_SYMBOL(rtw_power_mode_change);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rtw88: Fix an error message
  2019-10-07  8:48 [PATCH] rtw88: Fix an error message Dan Carpenter
@ 2019-10-09  8:27 ` Kalle Valo
  0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-10-09  8:27 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Yan-Hsuan Chuang, linux-wireless, kernel-janitors

Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The WARN_ON() macro doesn't take an error message, the argument is a
> condition so this won't display the warning message.
> 
> Fixes: 27e117e4b01b ("rtw88: add deep power save support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Patch applied to wireless-drivers-next.git, thanks.

be10b09b278f rtw88: Fix an error message

-- 
https://patchwork.kernel.org/patch/11176989/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rtw88: Fix an error message
  2019-08-14 10:46 Dan Carpenter
@ 2019-09-03 13:35 ` Kalle Valo
  0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-09-03 13:35 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Yan-Hsuan Chuang, linux-wireless, kernel-janitors

Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The WARN_ON() macro takes a condition, not a warning message.  I've
> changed this to use WARN() instead.
> 
> Fixes: 4136214f7c46 ("rtw88: add BT co-existence support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Patch applied to wireless-drivers-next.git, thanks.

52929cad3293 rtw88: Fix an error message

-- 
https://patchwork.kernel.org/patch/11093733/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] rtw88: Fix an error message
@ 2019-08-14 10:46 Dan Carpenter
  2019-09-03 13:35 ` Kalle Valo
  0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2019-08-14 10:46 UTC (permalink / raw)
  To: Yan-Hsuan Chuang; +Cc: Kalle Valo, linux-wireless, kernel-janitors

The WARN_ON() macro takes a condition, not a warning message.  I've
changed this to use WARN() instead.

Fixes: 4136214f7c46 ("rtw88: add BT co-existence support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/wireless/realtek/rtw88/coex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
index 4577fceddc5e..13701ec40302 100644
--- a/drivers/net/wireless/realtek/rtw88/coex.c
+++ b/drivers/net/wireless/realtek/rtw88/coex.c
@@ -1059,7 +1059,7 @@ static void rtw_coex_set_ant_path(struct rtw_dev *rtwdev, bool force, u8 phase)
 		pos_type = COEX_SWITCH_TO_WLG_BT;
 		break;
 	default:
-		WARN_ON("unknown phase when setting antenna path\n");
+		WARN(1, "unknown phase when setting antenna path\n");
 		return;
 	}
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07  8:48 [PATCH] rtw88: Fix an error message Dan Carpenter
2019-10-09  8:27 ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2019-08-14 10:46 Dan Carpenter
2019-09-03 13:35 ` Kalle Valo

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox