From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF444C47404 for ; Fri, 11 Oct 2019 11:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 987E0206CD for ; Fri, 11 Oct 2019 11:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dcyAOLXl"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="eCT6yiCW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727855AbfJKL5d (ORCPT ); Fri, 11 Oct 2019 07:57:33 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37928 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbfJKL5d (ORCPT ); Fri, 11 Oct 2019 07:57:33 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 173FC60ADE; Fri, 11 Oct 2019 11:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570795052; bh=EPYe5kTBBGci2tg48EPs5GLHdxzLBPQNaqpnWCbvN0A=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=dcyAOLXlc63HacOqTCRkTOezC44jm2EsyeUorxd4Y2Czh0nylMKLnukFv2yIPyDC6 gSEkVyhOQ9ZCuAADkDBMe2oepgpoWIS6GeGE5xrcy8lb2+J7dP2OL3jy6rJbjCP01C +IHbZyPOYgUzaj0GS9Nt+pRHzcpRXpJGfgV2qm1w= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B19BB602EE; Fri, 11 Oct 2019 11:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570795051; bh=EPYe5kTBBGci2tg48EPs5GLHdxzLBPQNaqpnWCbvN0A=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=eCT6yiCW4z23JIr4WE8iA1QhYZu/HoLLv/OdH8G5QEa5TVLcY4VigfBIS5uGhmp5d ds0tQP+w3Vc91Niy04tYYt51RBcWIsQeY182WQVCX9JPWZIQEo5T4etyqE2VxVguwl 07Ii9gVVw/vvgqEa50iIDZK8TnIqgB7yHP0PYHaI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B19BB602EE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath10k: Correct error check of dma_map_single() From: Kalle Valo In-Reply-To: <20191010162653.141303-1-bjorn.andersson@linaro.org> References: <20191010162653.141303-1-bjorn.andersson@linaro.org> To: Bjorn Andersson Cc: "David S. Miller" , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Niklas Cassel , stable@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191011115732.173FC60ADE@smtp.codeaurora.org> Date: Fri, 11 Oct 2019 11:57:32 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bjorn Andersson wrote: > The return value of dma_map_single() should be checked for errors using > dma_mapping_error(), rather than testing for NULL. Correct this. > > Fixes: 1807da49733e ("ath10k: wmi: add management tx by reference support over wmi") > Cc: stable@vger.kernel.org > Reported-by: Niklas Cassel > Signed-off-by: Bjorn Andersson Did this fix any real bug? Or is this just something found during code review? -- https://patchwork.kernel.org/patch/11183923/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches