* [PATCH] rtw88: include interrupt.h for tasklet_struct
@ 2019-10-12 1:44 Brian Norris
2019-10-14 6:05 ` Tony Chuang
2019-10-14 9:12 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Brian Norris @ 2019-10-12 1:44 UTC (permalink / raw)
To: linux-wireless; +Cc: Yan-Hsuan Chuang, Brian Norris
Depending on implicit header includes, we might see this compilation
error:
.../main.h:1391:24: error: field has incomplete type 'struct tasklet_struct'
struct tasklet_struct tx_tasklet;
^
Fixes: 3745d3e550d1 ("rtw88: add driver TX queue support")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/net/wireless/realtek/rtw88/main.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index f3eab96dba86..4759d6a0ca6e 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -11,6 +11,7 @@
#include <linux/average.h>
#include <linux/bitops.h>
#include <linux/bitfield.h>
+#include <linux/interrupt.h>
#include "util.h"
--
2.23.0.700.g56cf767bdb-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] rtw88: include interrupt.h for tasklet_struct
2019-10-12 1:44 [PATCH] rtw88: include interrupt.h for tasklet_struct Brian Norris
@ 2019-10-14 6:05 ` Tony Chuang
2019-10-14 9:12 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Tony Chuang @ 2019-10-14 6:05 UTC (permalink / raw)
To: Brian Norris, linux-wireless
> Subject: [PATCH] rtw88: include interrupt.h for tasklet_struct
>
> Depending on implicit header includes, we might see this compilation
> error:
>
> .../main.h:1391:24: error: field has incomplete type 'struct tasklet_struct'
> struct tasklet_struct tx_tasklet;
> ^
>
> Fixes: 3745d3e550d1 ("rtw88: add driver TX queue support")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Yan-Hsuan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtw88: include interrupt.h for tasklet_struct
2019-10-12 1:44 [PATCH] rtw88: include interrupt.h for tasklet_struct Brian Norris
2019-10-14 6:05 ` Tony Chuang
@ 2019-10-14 9:12 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-10-14 9:12 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-wireless, Yan-Hsuan Chuang, Brian Norris
Brian Norris <briannorris@chromium.org> wrote:
> Depending on implicit header includes, we might see this compilation
> error:
>
> .../main.h:1391:24: error: field has incomplete type 'struct tasklet_struct'
> struct tasklet_struct tx_tasklet;
> ^
>
> Fixes: 3745d3e550d1 ("rtw88: add driver TX queue support")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
c3226d93f85c rtw88: include interrupt.h for tasklet_struct
--
https://patchwork.kernel.org/patch/11186535/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-14 9:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-12 1:44 [PATCH] rtw88: include interrupt.h for tasklet_struct Brian Norris
2019-10-14 6:05 ` Tony Chuang
2019-10-14 9:12 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).