From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: <linux-wireless@vger.kernel.org>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Brian Norris <briannorris@chromium.org>,
Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH] rtw88: mark rtw_fw_hdr __packed
Date: Wed, 16 Oct 2019 07:35:51 +0000 (UTC) [thread overview]
Message-ID: <20191016073551.6B65960D74@smtp.codeaurora.org> (raw)
In-Reply-To: <20191014212648.122549-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> The use of u8 and __le16 in this struct assumes that it's going to be
> packed to byte alignment. C doesn't guarantee that, so we should mark
> this __packed.
>
> Fixes: cc20a7139836 ("rtw88: use struct rtw_fw_hdr to access firmware header")
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
89dca86d29b4 rtw88: mark rtw_fw_hdr __packed
--
https://patchwork.kernel.org/patch/11189429/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-10-16 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 21:26 [PATCH] rtw88: mark rtw_fw_hdr __packed Brian Norris
2019-10-16 7:35 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016073551.6B65960D74@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).