From: Tony Lindgren <tony@atomide.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Kalle Valo <kvalo@codeaurora.org>,
Wen Gong <wgong@codeaurora.org>,
Erik Stromdahl <erik.stromdahl@gmail.com>,
Eyal Reizer <eyalreizer@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 0/3] mmc: Fixup HW reset for SDIO cards
Date: Mon, 11 Nov 2019 14:08:12 -0800 [thread overview]
Message-ID: <20191111220812.GX43123@atomide.com> (raw)
In-Reply-To: <20191109103046.26445-1-ulf.hansson@linaro.org>
Hi,
* Ulf Hansson <ulf.hansson@linaro.org> [191109 10:31]:
> Changes in v2:
> - Add adaptations to the mwifiex driver.
> - Keep existing syncronous reset behaviour if the SDIO card has a single
> func driver.
>
> It has turned out that it's not a good idea to try to power cycle and to
> re-initialize the SDIO card, as currently done through mmc_hw_reset(). This
> because there may be multiple SDIO funcs attached to the same SDIO card and
> some of the others that didn't execute the call to mmc_hw_reset(), may then
> simply experience an undefined behaviour.
>
> The following patches in this series attempts to address this problem, by
> reworking the mmc_hw_reset() behaviour for SDIO and by adopting the Marvel
> mwifiex driver to these changes.
>
> Note that, I don't have the HW at hand so the the code has only compile tested.
> Test on HW is greatly appreciated!
Looks good to me. I tried testing this, but looks like at least on duovero
mwifiex_sdio is broken in v5.4-rc7:
# dmesg | grep mwifi
mwifiex_sdio mmc1:0001:1: poll card status failed, tries = 100
mwifiex_sdio mmc1:0001:1: FW download with helper: poll status timeout @ 0
mwifiex_sdio mmc1:0001:1: prog_fw failed ret=0xffffffff
mwifiex_sdio mmc1:0001:1: info: _mwifiex_fw_dpc: unregister device
No idea when it broke and what might be the issue this time around.
Any ideas?
Regards,
Tony
next prev parent reply other threads:[~2019-11-11 22:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 10:30 [PATCH v2 0/3] mmc: Fixup HW reset for SDIO cards Ulf Hansson
2019-11-09 10:30 ` [PATCH v2 1/3] mwifiex: Re-work support for SDIO HW reset Ulf Hansson
2019-11-12 0:33 ` Doug Anderson
2019-11-12 12:13 ` Ulf Hansson
2019-11-12 18:04 ` Doug Anderson
2019-11-13 15:00 ` Ulf Hansson
2019-11-09 10:30 ` [PATCH v2 2/3] mmc: core: Drop check for mmc_card_is_removable() in mmc_rescan() Ulf Hansson
2019-11-09 10:30 ` [PATCH v2 3/3] mmc: core: Re-work HW reset for SDIO cards Ulf Hansson
2019-11-12 0:33 ` Doug Anderson
2019-11-12 12:19 ` Ulf Hansson
2019-11-20 6:28 ` Kalle Valo
[not found] ` <87zhgr5af6.fsf@codeaurora.org>
2019-11-20 7:10 ` wgong
[not found] ` <6e6b53b28581a8f1a2944ca0bc65311e@codeaurora.org>
2019-11-20 7:20 ` Kalle Valo
[not found] ` <0101016e87aeb8b6-761ad812-5da7-4b0d-8cae-c69633d90de0-000000@us-west-2.amazonses.com>
2019-11-20 12:10 ` Ulf Hansson
2019-11-20 16:41 ` Kalle Valo
[not found] ` <87zhgqmref.fsf@kamboji.qca.qualcomm.com>
2019-11-21 2:29 ` wgong
2019-11-11 22:08 ` Tony Lindgren [this message]
2019-11-12 12:23 ` [PATCH v2 0/3] mmc: Fixup " Ulf Hansson
2019-11-12 18:00 ` Tony Lindgren
2019-11-12 0:51 ` Doug Anderson
2019-11-12 12:27 ` Ulf Hansson
2019-11-12 17:42 ` Doug Anderson
2019-11-13 15:11 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111220812.GX43123@atomide.com \
--to=tony@atomide.com \
--cc=adrian.hunter@intel.com \
--cc=dianders@chromium.org \
--cc=erik.stromdahl@gmail.com \
--cc=eyalreizer@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mka@chromium.org \
--cc=ulf.hansson@linaro.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).