From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: kvalo@codeaurora.org, davem@davemloft.net,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath10k: Handle "invalid" BDFs for msm8998 devices
Date: Tue, 12 Nov 2019 11:08:22 -0800 [thread overview]
Message-ID: <20191112190822.GA3140946@builder> (raw)
In-Reply-To: <20191106234712.2380-1-jeffrey.l.hugo@gmail.com>
On Wed 06 Nov 15:47 PST 2019, Jeffrey Hugo wrote:
> When the BDF download QMI message has the end field set to 1, it signals
> the end of the transfer, and triggers the firmware to do a CRC check. The
> BDFs for msm8998 devices fail this check, yet the firmware is happy to
> still use the BDF. It appears that this error is not caught by the
> downstream drive by concidence, therefore there are production devices
> in the field where this issue needs to be handled otherwise we cannot
> support wifi on them. So, attempt to detect this scenario as best we can
> and treat it as non-fatal.
>
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
> drivers/net/wireless/ath/ath10k/qmi.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
> index eb618a2652db..5ff8cfc93778 100644
> --- a/drivers/net/wireless/ath/ath10k/qmi.c
> +++ b/drivers/net/wireless/ath/ath10k/qmi.c
> @@ -265,10 +265,13 @@ static int ath10k_qmi_bdf_dnld_send_sync(struct ath10k_qmi *qmi)
> goto out;
>
> if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
> - ath10k_err(ar, "failed to download board data file: %d\n",
> - resp.resp.error);
> - ret = -EINVAL;
> - goto out;
> + if (!(req->end == 1 &&
> + resp.resp.result == QMI_ERR_MALFORMED_MSG_V01)) {
Perhaps worth adding a comment in the code as well, to describe what
scenario this relates to?
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> + ath10k_err(ar, "failed to download board data file: %d\n",
> + resp.resp.error);
> + ret = -EINVAL;
> + goto out;
> + }
> }
>
> remaining -= req->data_len;
> --
> 2.17.1
>
prev parent reply other threads:[~2019-11-12 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 23:47 [PATCH] ath10k: Handle "invalid" BDFs for msm8998 devices Jeffrey Hugo
2019-11-12 9:04 ` Simon Horman
2019-11-12 15:53 ` Jeffrey Hugo
2019-11-13 4:58 ` Kalle Valo
2019-11-13 7:00 ` Simon Horman
2019-11-12 19:08 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112190822.GA3140946@builder \
--to=bjorn.andersson@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).