From: David Miller <davem@davemloft.net>
To: alobakin@dlink.ru
Cc: pabeni@redhat.com, johannes@sipsolutions.net,
ecree@solarflare.com, nicholas.johnson-opensource@outlook.com.au,
jiri@mellanox.com, edumazet@google.com, idosch@mellanox.com,
petrm@mellanox.com, sd@queasysnail.net, f.fainelli@gmail.com,
jaswinder.singh@linaro.org, ilias.apalodimas@linaro.org,
linux-kernel@vger.kernel.org, emmanuel.grumbach@intel.com,
luciano.coelho@intel.com, linuxwifi@intel.com,
kvalo@codeaurora.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()
Date: Tue, 26 Nov 2019 15:57:46 -0800 (PST) [thread overview]
Message-ID: <20191126.155746.627765091618337419.davem@davemloft.net> (raw)
In-Reply-To: <d535d5142e42b8c550f0220200e3779d@dlink.ru>
From: Alexander Lobakin <alobakin@dlink.ru>
Date: Mon, 25 Nov 2019 15:02:24 +0300
> Paolo Abeni wrote 25.11.2019 14:42:
>> For -net, I *think* something as dumb and hacky as the following could
>> possibly work:
>> ----
>> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
>> b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
>> index 4bba6b8a863c..df82fad96cbb 100644
>> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
>> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
>> @@ -1527,7 +1527,7 @@ static void iwl_pcie_rx_handle(struct iwl_trans
>> *trans, int queue)
>> iwl_pcie_rxq_alloc_rbs(trans, GFP_ATOMIC, rxq);
>> if (rxq->napi.poll)
>> - napi_gro_flush(&rxq->napi, false);
>> + napi_complete_done(&rxq->napi, 0);
>> iwl_pcie_rxq_restock(trans, rxq);
>> }
>> ---
>
> napi_complete_done(napi, 0) has an equivalent static inline
> napi_complete(napi). I'm not sure it will work without any issues
> as iwlwifi doesn't _really_ turn NAPI into scheduling state.
>
> I'm not very familiar with iwlwifi, but as a work around manual
> napi_gro_flush() you can also manually flush napi->rx_list to
> prevent packets from stalling:
>
> diff -Naur a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c 2019-11-25
> --- 14:55:03.610355230 +0300
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c 2019-11-25
> 14:57:29.399556868 +0300
...
Thanks to everyone for looking into this.
Can I get some kind of fix in the next 24 hours? I want to send a quick
follow-on pull request to Linus to deal with all of the fallout, and in
particular fix this regression.
Thanks!
next prev parent reply other threads:[~2019-11-26 23:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191014080033.12407-1-alobakin@dlink.ru>
[not found] ` <20191015.181649.949805234862708186.davem@davemloft.net>
[not found] ` <7e68da00d7c129a8ce290229743beb3d@dlink.ru>
[not found] ` <PSXP216MB04388962C411CD0B17A86F47804A0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
[not found] ` <c762f5eee08a8f2d0d6cb927d7fa3848@dlink.ru>
2019-11-25 8:25 ` [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() Alexander Lobakin
2019-11-25 9:09 ` Nicholas Johnson
2019-11-25 10:31 ` Edward Cree
2019-11-25 10:58 ` Alexander Lobakin
2019-11-25 11:05 ` Johannes Berg
2019-11-25 11:42 ` Paolo Abeni
2019-11-25 12:02 ` Alexander Lobakin
2019-11-25 13:21 ` Edward Cree
2019-11-25 13:39 ` Alexander Lobakin
2019-11-26 23:57 ` David Miller [this message]
2019-11-27 7:47 ` Alexander Lobakin
2019-11-27 8:30 ` Johannes Berg
2019-11-27 9:47 ` Alexander Lobakin
2019-11-25 12:11 ` Kalle Valo
2019-11-25 13:07 ` Nicholas Johnson
2019-11-25 13:11 ` Nicholas Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126.155746.627765091618337419.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alobakin@dlink.ru \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=emmanuel.grumbach@intel.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=jiri@mellanox.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=pabeni@redhat.com \
--cc=petrm@mellanox.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).