From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2892AC43215 for ; Thu, 28 Nov 2019 17:07:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E451921739 for ; Thu, 28 Nov 2019 17:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574960833; bh=KzaQi2VU3GRVh6DkLnwabnycQAdlNqXBrjTNu6ldOUk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dVjIDR+R9tUbTQyenNfQ3BO4Aa4YOGramDavpT2V6x8nf5j8VB2NSsHHUFOin4a9q IUZMYUbHiVgiXJg2nskPB68YEthWj7ez4YXcIcl0sj2wLP74+LA6mTEvHiCWYNWpt2 gzttOgPj1qXyprvCdzeS8Cjq2mzS7QqgZpmFtgds= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbfK1RHJ (ORCPT ); Thu, 28 Nov 2019 12:07:09 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46168 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfK1RHI (ORCPT ); Thu, 28 Nov 2019 12:07:08 -0500 Received: by mail-lf1-f65.google.com with SMTP id a17so20516472lfi.13; Thu, 28 Nov 2019 09:07:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5oY62t5naKRuv8L01s6B5Y34B5Xp6xfia3KAGmKhm24=; b=E13FTBJz5U+bkhTWTOQtkJ1qhasda9v1tHHS4nqlkkROmcMNNuSydrNlclsBhIMyaR 15lgCHJTdSEJ+koDnUj+LeBhvRKdFUIIvUs/Iv9fWuhfVv5Dig03f32u6iId6mKJnitW mMiywNMZB2LlTYFbcmx2g1E3UGQBIqKfgrYkylon65maE8kzpLqG02D1uXs7TSs1dV96 mQq396zpxONoeqxz8K2GQaCGLE0Bf+MpGIlXzR/Z3zwFqC3eyypY7swgOYGusM2DRZRA 2EHlxhfF8VJfmd/2FiBlfbitrg27J7zF2mlAn3nhmlQ6zU4G+0PA7ywUZUqmNKdrb5Jo t7CA== X-Gm-Message-State: APjAAAUZ62GohYnZEn/ltT+cFtiNo35MgMZiP2L51dlQC4q+aRoxYd++ zilwC5+v8WKiiTqy9CQoai8= X-Google-Smtp-Source: APXvYqxNZ4xuC7os02A5+AxB3brfiNhp4xrTNjiupt9gtBNq5tnvg3cgH+cVDqSkKnLtFwikGakwkQ== X-Received: by 2002:ac2:5549:: with SMTP id l9mr9639279lfk.53.1574960823164; Thu, 28 Nov 2019 09:07:03 -0800 (PST) Received: from xi.terra (c-14b8e655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.184.20]) by smtp.gmail.com with ESMTPSA id y5sm8797747lfg.5.2019.11.28.09.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 09:07:02 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.92.3) (envelope-from ) id 1iaNFu-0006of-E9; Thu, 28 Nov 2019 18:07:02 +0100 Date: Thu, 28 Nov 2019 18:07:02 +0100 From: Johan Hovold To: Andrey Konovalov Cc: syzbot , amitkarwar@gmail.com, "David S. Miller" , Kalle Valo , LKML , USB list , linux-wireless@vger.kernel.org, netdev , siva8118@gmail.com, syzkaller-bugs Subject: Re: KASAN: invalid-free in rsi_91x_deinit Message-ID: <20191128170702.GA29518@localhost> References: <0000000000005ae4cd058731d407@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Nov 19, 2019 at 02:38:11PM +0100, Andrey Konovalov wrote: > On Tue, Apr 23, 2019 at 2:36 PM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit: d34f9519 usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com/google/kasan/tree/usb-fuzzer > > console output: https://syzkaller.appspot.com/x/log.txt?x=14a79403200000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=c73d1bb5aeaeae20 > > dashboard link: https://syzkaller.appspot.com/bug?extid=7c72edfb407b2bd866ce > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17547247200000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=147b3a1d200000 > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+7c72edfb407b2bd866ce@syzkaller.appspotmail.com > > > > usb 1-1: config 252 interface 115 altsetting 0 has 1 endpoint descriptor, > > different from the interface descriptor's value: 4 > > usb 1-1: New USB device found, idVendor=1618, idProduct=9113, > > bcdDevice=32.21 > > usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0 > > rsi_91x: rsi_probe: Failed to init usb interface > > ================================================================== > > BUG: KASAN: double-free or invalid-free in slab_free mm/slub.c:3003 [inline] > > BUG: KASAN: double-free or invalid-free in kfree+0xce/0x280 mm/slub.c:3958 > > > > CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.1.0-rc5-319617-gd34f951 #4 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > > Google 01/01/2011 > > Workqueue: usb_hub_wq hub_event > > Call Trace: > > __dump_stack lib/dump_stack.c:77 [inline] > > dump_stack+0xe8/0x16e lib/dump_stack.c:113 > > print_address_description+0x6c/0x236 mm/kasan/report.c:187 > > kasan_report_invalid_free+0x66/0xa0 mm/kasan/report.c:278 > > __kasan_slab_free+0x162/0x180 mm/kasan/common.c:438 > > slab_free_hook mm/slub.c:1429 [inline] > > slab_free_freelist_hook+0x5e/0x140 mm/slub.c:1456 > > slab_free mm/slub.c:3003 [inline] > > kfree+0xce/0x280 mm/slub.c:3958 > > rsi_91x_deinit+0x27b/0x300 drivers/net/wireless/rsi/rsi_91x_main.c:407 > > rsi_probe+0xdf3/0x140d drivers/net/wireless/rsi/rsi_91x_sdio.c:1178 > > usb_probe_interface+0x31d/0x820 drivers/usb/core/driver.c:361 > > really_probe+0x2da/0xb10 drivers/base/dd.c:509 > > driver_probe_device+0x21d/0x350 drivers/base/dd.c:671 > > __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778 > > bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454 > > __device_attach+0x223/0x3a0 drivers/base/dd.c:844 > > bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514 > > device_add+0xad2/0x16e0 drivers/base/core.c:2106 > > usb_set_configuration+0xdf7/0x1740 drivers/usb/core/message.c:2021 > > generic_probe+0xa2/0xda drivers/usb/core/generic.c:210 > > usb_probe_device+0xc0/0x150 drivers/usb/core/driver.c:266 > > really_probe+0x2da/0xb10 drivers/base/dd.c:509 > > driver_probe_device+0x21d/0x350 drivers/base/dd.c:671 > > __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778 > > bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454 > > __device_attach+0x223/0x3a0 drivers/base/dd.c:844 > > bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514 > > device_add+0xad2/0x16e0 drivers/base/core.c:2106 > > usb_new_device.cold+0x537/0xccf drivers/usb/core/hub.c:2534 > > hub_port_connect drivers/usb/core/hub.c:5089 [inline] > > hub_port_connect_change drivers/usb/core/hub.c:5204 [inline] > > port_event drivers/usb/core/hub.c:5350 [inline] > > hub_event+0x1398/0x3b00 drivers/usb/core/hub.c:5432 > > process_one_work+0x90f/0x1580 kernel/workqueue.c:2269 > > worker_thread+0x9b/0xe20 kernel/workqueue.c:2415 > > kthread+0x313/0x420 kernel/kthread.c:253 > > ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352 > > > > Allocated by task 12: > > set_track mm/kasan/common.c:87 [inline] > > __kasan_kmalloc mm/kasan/common.c:497 [inline] > > __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:470 > > rsi_init_sdio_interface drivers/net/wireless/rsi/rsi_91x_sdio.c:853 > > [inline] > > rsi_probe+0x11a/0x140d drivers/net/wireless/rsi/rsi_91x_sdio.c:965 > > usb_probe_interface+0x31d/0x820 drivers/usb/core/driver.c:361 > > really_probe+0x2da/0xb10 drivers/base/dd.c:509 > > driver_probe_device+0x21d/0x350 drivers/base/dd.c:671 > > __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778 > > bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454 > > __device_attach+0x223/0x3a0 drivers/base/dd.c:844 > > bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514 > > device_add+0xad2/0x16e0 drivers/base/core.c:2106 > > usb_set_configuration+0xdf7/0x1740 drivers/usb/core/message.c:2021 > > generic_probe+0xa2/0xda drivers/usb/core/generic.c:210 > > usb_probe_device+0xc0/0x150 drivers/usb/core/driver.c:266 > > really_probe+0x2da/0xb10 drivers/base/dd.c:509 > > driver_probe_device+0x21d/0x350 drivers/base/dd.c:671 > > __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778 > > bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454 > > __device_attach+0x223/0x3a0 drivers/base/dd.c:844 > > bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514 > > device_add+0xad2/0x16e0 drivers/base/core.c:2106 > > usb_new_device.cold+0x537/0xccf drivers/usb/core/hub.c:2534 > > hub_port_connect drivers/usb/core/hub.c:5089 [inline] > > hub_port_connect_change drivers/usb/core/hub.c:5204 [inline] > > port_event drivers/usb/core/hub.c:5350 [inline] > > hub_event+0x1398/0x3b00 drivers/usb/core/hub.c:5432 > > process_one_work+0x90f/0x1580 kernel/workqueue.c:2269 > > worker_thread+0x9b/0xe20 kernel/workqueue.c:2415 > > kthread+0x313/0x420 kernel/kthread.c:253 > > ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352 > > > > Freed by task 12: > > set_track mm/kasan/common.c:87 [inline] > > __kasan_slab_free+0x130/0x180 mm/kasan/common.c:459 > > slab_free_hook mm/slub.c:1429 [inline] > > slab_free_freelist_hook+0x5e/0x140 mm/slub.c:1456 > > slab_free mm/slub.c:3003 [inline] > > kfree+0xce/0x280 mm/slub.c:3958 > > rsi_probe+0xf04/0x140d drivers/net/wireless/rsi/rsi_91x_sdio.c:1196 > > usb_probe_interface+0x31d/0x820 drivers/usb/core/driver.c:361 > > really_probe+0x2da/0xb10 drivers/base/dd.c:509 > > driver_probe_device+0x21d/0x350 drivers/base/dd.c:671 > > __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778 > > bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454 > > __device_attach+0x223/0x3a0 drivers/base/dd.c:844 > > bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514 > > device_add+0xad2/0x16e0 drivers/base/core.c:2106 > > usb_set_configuration+0xdf7/0x1740 drivers/usb/core/message.c:2021 > > generic_probe+0xa2/0xda drivers/usb/core/generic.c:210 > > usb_probe_device+0xc0/0x150 drivers/usb/core/driver.c:266 > > really_probe+0x2da/0xb10 drivers/base/dd.c:509 > > driver_probe_device+0x21d/0x350 drivers/base/dd.c:671 > > __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778 > > bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454 > > __device_attach+0x223/0x3a0 drivers/base/dd.c:844 > > bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514 > > device_add+0xad2/0x16e0 drivers/base/core.c:2106 > > usb_new_device.cold+0x537/0xccf drivers/usb/core/hub.c:2534 > > hub_port_connect drivers/usb/core/hub.c:5089 [inline] > > hub_port_connect_change drivers/usb/core/hub.c:5204 [inline] > > port_event drivers/usb/core/hub.c:5350 [inline] > > hub_event+0x1398/0x3b00 drivers/usb/core/hub.c:5432 > > process_one_work+0x90f/0x1580 kernel/workqueue.c:2269 > > worker_thread+0x9b/0xe20 kernel/workqueue.c:2415 > > kthread+0x313/0x420 kernel/kthread.c:253 > > ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352 > > > > The buggy address belongs to the object at ffff888214af0c80 > > which belongs to the cache kmalloc-512 of size 512 > > The buggy address is located 0 bytes inside of > > 512-byte region [ffff888214af0c80, ffff888214af0e80) > > The buggy address belongs to the page: > > page:ffffea000852bc00 count:1 mapcount:0 mapping:ffff88812c3f4c00 > > index:0xffff888214af1180 compound_mapcount: 0 > > flags: 0x57ff00000010200(slab|head) > > raw: 057ff00000010200 ffffea00086b3780 0000000800000008 ffff88812c3f4c00 > > raw: ffff888214af1180 00000000800c000a 00000001ffffffff 0000000000000000 > > page dumped because: kasan: bad access detected > > > > Memory state around the buggy address: > > ffff888214af0b80: 00 00 00 00 00 00 00 00 00 00 00 fc fc fc fc fc > > ffff888214af0c00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc > > > ffff888214af0c80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > ^ > > ffff888214af0d00: fb fb fb fb fb fb f > > > > > > --- > > This bug is generated by a bot. It may contain errors. > > See https://goo.gl/tpsmEJ for more information about syzbot. > > syzbot engineers can be reached at syzkaller@googlegroups.com. > > > > syzbot will keep track of this bug report. See: > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > syzbot can test patches for this bug, for details see: > > https://goo.gl/tpsmEJ#testing-patches > > Most likely the same issue as: > > #syz dup: WARNING: ODEBUG bug in rsi_probe > > https://syzkaller.appspot.com/bug?extid=1d1597a5aa3679c65b9f No, this was separate bug that was fixed by commit 8b51dc729147 ("rsi: fix a double free bug in rsi_91x_deinit()"). Let me try to mark it as such: #syz undup Johan