From: Stanislaw Gruszka <sgruszka@redhat.com> To: Exuvo <exuvo@exuvo.se> Cc: linux-wireless@vger.kernel.org, Helmut Schaa <helmut.schaa@googlemail.com> Subject: Re: rt2x00 regression Date: Tue, 3 Dec 2019 08:57:36 +0100 [thread overview] Message-ID: <20191203075736.GA701@redhat.com> (raw) In-Reply-To: <CA+GwT0B5SyRZnGLqwqOeuJK4CWMVc=dKaWre9VN8KQC6kBzKGw@mail.gmail.com> On Mon, Dec 02, 2019 at 05:40:20PM +0100, Exuvo wrote: > Sorry for the late reply > > The patch for increasing the amount did not work, i'll get around to > testing with the commit reverted. So, revert of that commit makes the problem gone ? > As an aside what function can i call at that point in the code to print the > value in num_proto_errs? I assume some kernel special printf? It's printk. You can add line like this to print values: printk("status %d num_proto_errs %u\n", status, rt2x00dev->num_proto_errs); Stanislaw > On Fri, 27 Sep 2019, 10:03 Stanislaw Gruszka, <sgruszka@redhat.com> wrote: > > > On Thu, Sep 26, 2019 at 06:32:23PM +0200, Anton Olsson wrote: > > > Hello I have a USB based ID 148f:3070 Ralink Technology, Corp. > > RT2870/RT3070 Wireless Adapter, that stops working with recent kernels. It > > works on kernel 5.1.15 and does not work with 5.2.7 or 5.3.1 (I have not > > tested other versions). I use it in AP mode. > > > > > > I found this similar bug report > > https://marc.info/?l=linux-wireless&m=156630037103575&w=2 but that did > > not have related error messages so I assume this is different? > > > > > > Logs of working kernel 5.1.15-arch1-1-ARCH. > > > [ 78.680555] ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 3070, > > rev 0201 detected > > > [ 78.690992] ieee80211 phy0: rt2x00_set_rf: Info - RF chipset 0005 > > detected > > > [ 78.799625] ieee80211 phy0: Selected rate control algorithm > > 'minstrel_ht' > > > sep 26 17:13:03 kernel: usbcore: registered new interface driver > > rt2800usb > > > sep 26 17:13:03 systemd[1]: Found device RT2870/RT3070 Wireless Adapter. > > > [ 113.812454] ieee80211 phy0: rt2x00lib_request_firmware: Info - > > Loading firmware file 'rt2870.bin' > > > [ 113.905279] ieee80211 phy0: rt2x00lib_request_firmware: Info - > > Firmware detected - version: 0.36 > > > [ 114.028703] ieee80211 phy0: rt2x00usb_vendor_request: Error - Vendor > > Request 0x06 failed for offset 0x0404 with error -71 > > > > > > The last error there does not seem to affect the operation of the device. > > > > > > Logs of not working with kernel 5.3.1, 5.2.7 has similar output. > > > sep 26 17:06:12 kernel: ieee80211 phy0: rt2x00_set_rt: Info - RT chipset > > 3070, rev 0201 detected > > > sep 26 17:06:12 kernel: ieee80211 phy0: rt2x00_set_rf: Info - RF chipset > > 0005 detected > > > sep 26 17:06:12 kernel: ieee80211 phy0: Selected rate control algorithm > > 'minstrel_ht' > > > sep 26 17:06:12 kernel: usbcore: registered new interface driver > > rt2800usb > > > sep 26 17:06:12 systemd[1]: Found device RT2870/RT3070 Wireless Adapter. > > > sep 26 17:06:21 ieee80211 phy0: rt2x00lib_request_firmware: Info - > > Loading firmware file 'rt2870.bin' > > > sep 26 17:06:21 ieee80211 phy0: rt2x00lib_request_firmware: Info - > > Firmware detected - version: 0.36 > > > sep 26 17:06:21 ieee80211 phy0: rt2x00usb_vendor_request: Error - Vendor > > Request 0x06 failed for offset 0x0404 with> > > > sep 26 17:06:22 ieee80211 phy0: rt2800_wait_csr_ready: Error - Unstable > > hardware > > > sep 26 17:06:22 ieee80211 phy0: rt2800usb_set_device_state: Error - > > Device failed to enter state 4 (-5) > > > > > > Unable to bring up the network interface here. > > > > This most likely is the problem introduced by commit: > > > > commit e383c70474db32b9d4a3de6dfbd08784d19e6751 > > Author: Stanislaw Gruszka <sgruszka@redhat.com> > > Date: Tue Mar 12 10:51:42 2019 +0100 > > > > rt2x00: check number of EPROTO errors > > > > Plase check below patch that increase number of EPROTO checks > > before marking device removed. If it does not help, plese > > check if reverting above commits helps. > > > > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c > > b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c > > index bc2dfef0de22..215c3f092306 100644 > > --- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c > > +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c > > @@ -30,7 +30,7 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_dev > > *rt2x00dev, int status) > > else > > rt2x00dev->num_proto_errs = 0; > > > > - if (rt2x00dev->num_proto_errs > 3) > > + if (rt2x00dev->num_proto_errs > 8) > > return true; > > > > return false; > >
next prev parent reply other threads:[~2019-12-03 7:57 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-26 16:32 Anton Olsson 2019-09-27 8:03 ` Stanislaw Gruszka [not found] ` <CA+GwT0B5SyRZnGLqwqOeuJK4CWMVc=dKaWre9VN8KQC6kBzKGw@mail.gmail.com> 2019-12-03 7:57 ` Stanislaw Gruszka [this message] 2019-12-03 18:50 ` Anton Olsson 2020-04-05 4:58 ` Anton Olsson 2020-07-15 19:47 ` Anton Olsson 2021-09-29 8:22 ` Exuvo 2021-10-01 6:56 ` Kalle Valo 2021-11-05 13:25 ` Thorsten Leemhuis 2021-11-08 18:00 ` Thorsten Leemhuis [not found] ` <20211109073127.ga109212@wp.pl> 2021-11-09 7:31 ` Stanislaw Gruszka 2021-11-09 12:07 ` Stanislaw Gruszka 2021-11-09 15:22 ` Exuvo [not found] ` <cc85b4e8a038417b865069c6578acf50@grupawp.pl> 2021-11-10 6:59 ` Kalle Valo 2021-11-10 8:01 ` Stanislaw Gruszka 2021-11-11 10:54 ` Exuvo 2021-11-11 14:10 ` [PATCH] rt2x00: do not mark device gone on EPROTO errors during start Stanislaw Gruszka 2021-11-18 6:16 ` Thorsten Leemhuis 2021-11-19 14:19 ` Kalle Valo 2021-11-29 10:54 ` Kalle Valo [not found] <ca+gwt0b5syrznglqwqoeujk4cwmvc=dkawre9vn8kqc6kbzkgw@mail.gmail.com>
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191203075736.GA701@redhat.com \ --to=sgruszka@redhat.com \ --cc=exuvo@exuvo.se \ --cc=helmut.schaa@googlemail.com \ --cc=linux-wireless@vger.kernel.org \ --subject='Re: rt2x00 regression' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).