From: Mehmet Akif Tasova <makiftasova@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: makiftasova@gmail.com, Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Shahar S Matityahu <shahar.s.matityahu@intel.com>,
Tova Mussai <tova.mussai@intel.com>,
Ayala Beker <ayala.beker@intel.com>,
Sara Sharon <sara.sharon@intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] Revert "iwlwifi: mvm: fix scan config command size"
Date: Fri, 13 Dec 2019 23:35:10 +0300 [thread overview]
Message-ID: <20191213203512.8250-1-makiftasova@gmail.com> (raw)
Since Linux 5.4.1 released, iwlwifi could not initialize Intel(R) Dual Band
Wireless AC 9462 firmware, failing with following error in dmesg:
iwlwifi 0000:00:14.3: FW error in SYNC CMD SCAN_CFG_CMD
whole dmesg output of error can be found at:
https://gist.github.com/makiftasova/354e46439338f4ab3fba0b77ad5c19ec
also bug report from ArchLinux bug tracker (contains more info):
https://bugs.archlinux.org/task/64703
Reverting commit 06eb547c4ae4 ("iwlwifi: mvm: fix scan config command
size") seems to fix this issue until proper solution is found.
This reverts commit 06eb547c4ae4382e70d556ba213d13c95ca1801b.
Signed-off-by: Mehmet Akif Tasova <makiftasova@gmail.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
index a046ac9fa852..a5af8f4128b1 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
@@ -1213,7 +1213,7 @@ static int iwl_mvm_legacy_config_scan(struct iwl_mvm *mvm)
cmd_size = sizeof(struct iwl_scan_config_v2);
else
cmd_size = sizeof(struct iwl_scan_config_v1);
- cmd_size += num_channels;
+ cmd_size += mvm->fw->ucode_capa.n_scan_channels;
cfg = kzalloc(cmd_size, GFP_KERNEL);
if (!cfg)
--
2.24.1
next reply other threads:[~2019-12-13 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 20:35 Mehmet Akif Tasova [this message]
2019-12-18 19:12 ` [PATCH] Revert "iwlwifi: mvm: fix scan config command size" Roman Gilg
[not found] ` <CAP=YcKGLDx_coFsY7ej6BkdBJT+FELGSOMM6YM_r7jgqEsvChw@mail.gmail.com>
2019-12-19 10:15 ` Mehmet Akif Tasova
2019-12-23 12:24 ` Thomas Backlund
2019-12-23 13:52 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213203512.8250-1-makiftasova@gmail.com \
--to=makiftasova@gmail.com \
--cc=ayala.beker@intel.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sara.sharon@intel.com \
--cc=shahar.s.matityahu@intel.com \
--cc=tova.mussai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).