Linux-Wireless Archive on
 help / color / Atom feed
* [PATCH] rfkill: Fix incorrect check to avoid NULL pointer dereference
@ 2019-12-15 15:34 Aditya Pakki
  0 siblings, 0 replies; only message in thread
From: Aditya Pakki @ 2019-12-15 15:34 UTC (permalink / raw)
  To: pakki001
  Cc: kjlu, Johannes Berg, David S. Miller, linux-wireless, netdev,

In rfkill_register, the struct rfkill pointer is first derefernced
and then checked for NULL. This patch removes the BUG_ON and returns
an error to the caller in case rfkill is NULL.

Signed-off-by: Aditya Pakki <>
 net/rfkill/core.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index 461d75274fb3..971c73c7d34c 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -1002,10 +1002,13 @@ static void rfkill_sync_work(struct work_struct *work)
 int __must_check rfkill_register(struct rfkill *rfkill)
 	static unsigned long rfkill_no;
-	struct device *dev = &rfkill->dev;
+	struct device *dev;
 	int error;
-	BUG_ON(!rfkill);
+	if (!rfkill)
+		return -EINVAL;
+	dev = &rfkill->dev;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-15 15:34 [PATCH] rfkill: Fix incorrect check to avoid NULL pointer dereference Aditya Pakki

Linux-Wireless Archive on

Archives are clonable:
	git clone --mirror linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ \
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone