From: <yhchuang@realtek.com>
To: <kvalo@codeaurora.org>
Cc: <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>
Subject: [PATCH 10/11] rtw88: assign NULL to skb after being kfree()'ed
Date: Fri, 20 Dec 2019 17:21:55 +0800 [thread overview]
Message-ID: <20191220092156.13443-11-yhchuang@realtek.com> (raw)
In-Reply-To: <20191220092156.13443-1-yhchuang@realtek.com>
From: Yan-Hsuan Chuang <yhchuang@realtek.com>
Should assign NULL to skb after kfree(), in case of driver
trying to free the same skb again.
This could happen if driver failed to allocate an skb when
building reserved page.
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
---
drivers/net/wireless/realtek/rtw88/fw.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index b8c581161f61..92cefb79e09b 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -857,13 +857,16 @@ static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev,
page += rtw_len_to_page(rsvd_pkt->skb->len, page_size);
kfree_skb(rsvd_pkt->skb);
+ rsvd_pkt->skb = NULL;
}
return buf;
release_skb:
- list_for_each_entry(rsvd_pkt, &rtwdev->rsvd_page_list, list)
+ list_for_each_entry(rsvd_pkt, &rtwdev->rsvd_page_list, list) {
kfree_skb(rsvd_pkt->skb);
+ rsvd_pkt->skb = NULL;
+ }
return NULL;
}
--
2.17.1
next prev parent reply other threads:[~2019-12-20 9:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 9:21 [PATCH 00/11] rtw88: some driver fixes yhchuang
2019-12-20 9:21 ` [PATCH 01/11] rtw88: fix rate mask for 1SS chip yhchuang
2019-12-24 7:10 ` Chris Chiu
2020-01-26 15:38 ` Kalle Valo
2020-01-26 15:39 ` Kalle Valo
2019-12-20 9:21 ` [PATCH 02/11] rtw88: fix TX secondary channel offset of 40M if current bw is 20M or 40M yhchuang
2019-12-20 9:21 ` [PATCH 03/11] rtw88: Use secondary channel offset enumeration yhchuang
2019-12-24 7:18 ` Chris Chiu
2019-12-24 7:44 ` Tony Chuang
2019-12-20 9:21 ` [PATCH 04/11] rtw88: 8822c: update power sequence to v15 yhchuang
2019-12-20 9:21 ` [PATCH 05/11] rtw88: 8822c: modify rf protection setting yhchuang
2019-12-24 7:39 ` Chris Chiu
2019-12-24 7:50 ` Tony Chuang
2019-12-24 8:17 ` Chris Chiu
2019-12-20 9:21 ` [PATCH 06/11] rtw88: remove unused spinlock yhchuang
2019-12-20 9:21 ` [PATCH 07/11] rtw88: remove unused variable 'in_lps' yhchuang
2019-12-20 9:21 ` [PATCH 08/11] rtw88: remove unused vif pointer in struct rtw_vif yhchuang
2019-12-20 9:21 ` [PATCH 09/11] rtw88: use rtw_hci_stop() instead of rtwdev->hci.ops->stop() yhchuang
2019-12-20 9:21 ` yhchuang [this message]
2019-12-20 9:21 ` [PATCH 11/11] rtw88: change max_num_of_tx_queue() definition to inline in pci.h yhchuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220092156.13443-11-yhchuang@realtek.com \
--to=yhchuang@realtek.com \
--cc=briannorris@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).