From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0E4C33CAF for ; Thu, 16 Jan 2020 17:33:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63EB5246A1 for ; Thu, 16 Jan 2020 17:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196032; bh=uCIp6mD10XteebAJ2I2AXoP9KgVklKyDJoPbZYmlV6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ImqXzas7O6HCP0dwSMUIGEDgp7li5ZPn/Mbrgi1IauHwc73f3GQrjlOrepfSnioOP aDLWtZeWCL3CtsCz6asLG/UYR512gFOsmjYWSDE/N3WJsa536rB+NCJw5akqTz4PE/ 5oA0vo6/UIqhIFszK3m14Irtf8eFYp4PSyiIsEMs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404402AbgAPRaV (ORCPT ); Thu, 16 Jan 2020 12:30:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:42898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404390AbgAPRaV (ORCPT ); Thu, 16 Jan 2020 12:30:21 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 832BB24726; Thu, 16 Jan 2020 17:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195820; bh=uCIp6mD10XteebAJ2I2AXoP9KgVklKyDJoPbZYmlV6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EKnE3BbCCwbKiYb1Cb6ItrgLsxO4MxGjZXquMNbt/wJeOvnYMgqXmRdXjMJKGnMTk qklFBb1+SP8mPlkuXZFpP/9ejnsRBb4FrduJPGnaZo1EZ9kbHwvThJgM+3fvD9yejE YalXxsqT797J1m/1sgGDjTmxOPylswYRVCI81yd0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lorenzo Bianconi , Jakub Kicinski , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 4.14 329/371] mt7601u: fix bbp version check in mt7601u_wait_bbp_ready Date: Thu, 16 Jan 2020 12:23:21 -0500 Message-Id: <20200116172403.18149-272-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Lorenzo Bianconi [ Upstream commit 15e14f76f85f4f0eab3b8146e1cd3c58ce272823 ] Fix bbp ready check in mt7601u_wait_bbp_ready. The issue is reported by coverity with the following error: Logical vs. bitwise operator The expression's value does not depend on the operands; inadvertent use of the wrong operator is a likely logic error. Addresses-Coverity-ID: 1309441 ("Logical vs. bitwise operator") Fixes: c869f77d6abb ("add mt7601u driver") Acked-by: Jakub Kicinski Signed-off-by: Lorenzo Bianconi Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt7601u/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c index ca09a5d4305e..71a47459bf8a 100644 --- a/drivers/net/wireless/mediatek/mt7601u/phy.c +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c @@ -221,7 +221,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) do { val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); - if (val && ~val) + if (val && val != 0xff) break; } while (--i); -- 2.20.1