Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ajay.Kathat@microchip.com
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
	johannes@sipsolutions.net, Adham.Abozaeid@microchip.com,
	Nicolas.Ferre@microchip.com, Claudiu.Beznea@microchip.com,
	Venkateswara.Kaja@microchip.com
Subject: Re: [PATCH v4 16/18] dt: bindings: net: add microchip,wilc1000,sdio.yaml
Date: Mon, 2 Mar 2020 19:55:58 -0600
Message-ID: <20200303015558.GA6876@bogus> (raw)
In-Reply-To: <20200302163414.4342-17-ajay.kathat@microchip.com>

On Mon, Mar 02, 2020 at 04:34:40PM +0000, Ajay.Kathat@microchip.com wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
> 
> Moved '/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml' to
> 'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml'.
> 
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> ---
>  .../net/wireless/microchip,wilc1000,sdio.yaml | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
> new file mode 100644
> index 000000000000..b338f569f7e2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/microchip,wilc1000,sdio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip WILC wireless SDIO devicetree bindings
> +
> +maintainers:
> +  - Adham Abozaeid <adham.abozaeid@microchip.com>
> +  - Ajay Singh <ajay.kathat@microchip.com>
> +
> +description:
> +  The wilc1000 chips can be connected via SDIO. The node is used to
> +  specify child node to the SDIO controller that connects the device
> +  to the system.
> +
> +properties:
> +  compatible:
> +    const: microchip,wilc1000-sdio
> +
> +  irq-gpios:

Unless you need GPIO control of the line, use 'interrupts' instead.

> +    description: The GPIO phandle connect to a host IRQ.
> +    maxItems: 1
> +
> +  reg:
> +    description: Slot ID used in the controller.

No, it's the function number. But you can just drop this.

> +    maxItems: 1
> +
> +  clocks:
> +    description: phandle to the clock connected on rtc clock line.
> +    maxItems: 1
> +
> +  bus-width:

I believe this is defined to go in the parent node.

> +    description: The number of data lines wired up the slot.
> +    allOf:
> +      - $ref: /schemas/types.yaml#/definitions/uint32
> +      - enum: [1, 4, 8]
> +      - default: 1
> +
> +required:
> +  - compatible
> +  - irq-gpios
> +  - reg
> +
> +examples:
> +  - |
> +    mmc1: mmc@fc000000 {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_mmc1_clk_cmd_dat0 &pinctrl_mmc1_dat1_3>;
> +      non-removable;
> +      vmmc-supply = <&vcc_mmc1_reg>;
> +      vqmmc-supply = <&vcc_3v3_reg>;
> +      status = "okay";

Don't show 'status' in examples.

> +      wilc_sdio@0 {

wifi@0

> +        compatible = "microchip,wilc1000-sdio";
> +          irq-gpios = <&pioC 27 0>;
> +          reg = <0>;
> +          clocks = <&pck1>;
> +          clock-names = "rtc_clk";
> +          assigned-clocks = <&pck1>;
> +          assigned-clock-rates = <32768>;
> +          status = "okay";
> +          bus-width = <4>;
> +        };
> +    };
> -- 
> 2.24.0

  reply index

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 16:34 [PATCH v4 00/18] wilc1000: move out of staging Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 01/18] wilc1000: add hif.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 02/18] wilc1000: add hif.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 03/18] wilc1000: add wlan_if.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 04/18] wilc1000: add wlan_cfg.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 06/18] wilc1000: add cfg80211.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 05/18] wilc1000: add wlan_cfg.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 07/18] wilc1000: add cfg80211.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 09/18] wilc1000: add netdev.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 08/18] wilc1000: add netdev.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 10/18] wilc1000: add mon.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 12/18] wilc1000: add wlan.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 11/18] wilc1000: add spi.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 13/18] wilc1000: add wlan.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 14/18] wilc1000: add sdio.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 15/18] wilc1000: add fw.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 17/18] dt: bindings: net: add microchip,wilc1000,spi.yaml Ajay.Kathat
2020-03-03  2:02   ` Rob Herring
2020-03-03 12:45     ` Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 16/18] dt: bindings: net: add microchip,wilc1000,sdio.yaml Ajay.Kathat
2020-03-03  1:55   ` Rob Herring [this message]
2020-03-03 12:28     ` Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 18/18] wilc1000: add Makefile and Kconfig files for wilc1000 compilation Ajay.Kathat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303015558.GA6876@bogus \
    --to=robh@kernel.org \
    --cc=Adham.Abozaeid@microchip.com \
    --cc=Ajay.Kathat@microchip.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=Venkateswara.Kaja@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git