From: Rob Herring <robh@kernel.org>
To: Ajay.Kathat@microchip.com
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
johannes@sipsolutions.net, Adham.Abozaeid@microchip.com,
Nicolas.Ferre@microchip.com, Claudiu.Beznea@microchip.com,
Venkateswara.Kaja@microchip.com
Subject: Re: [PATCH v4 17/18] dt: bindings: net: add microchip,wilc1000,spi.yaml
Date: Mon, 2 Mar 2020 20:02:30 -0600 [thread overview]
Message-ID: <20200303020230.GA15543@bogus> (raw)
In-Reply-To: <20200302163414.4342-18-ajay.kathat@microchip.com>
On Mon, Mar 02, 2020 at 04:34:40PM +0000, Ajay.Kathat@microchip.com wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
>
> Moved '/drivers/staging/wilc1000//microchip,wilc1000,spi.yaml' to
> 'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,spi.yaml'.
Not a useful changelog.
I think this should be combined with the SDIO version. Details below.
>
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> ---
> .../net/wireless/microchip,wilc1000,spi.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,spi.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,spi.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,spi.yaml
> new file mode 100644
> index 000000000000..cc8ed64ce627
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,spi.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/microchip,wilc1000,spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip WILC wireless SPI devicetree bindings
> +
> +maintainers:
> + - Adham Abozaeid <adham.abozaeid@microchip.com>
> + - Ajay Singh <ajay.kathat@microchip.com>
> +
> +description:
> + The wilc1000 chips can be connected via SPI. This document describes
> + the binding for the SPI connected module.
> +
> +properties:
> + compatible:
> + const: microchip,wilc1000-spi
You can drop '-spi' (and '-sdio'). They don't need to be different
because they already sit on different buses.
> +
> + spi-max-frequency:
> + description: Maximum SPI clocking speed of device in Hz.
> + maxItems: 1
> +
> + reg:
> + description: Chip select address of device.
> + maxItems: 1
> +
> + irq-gpios:
> + description: The GPIO phandle connect to a host IRQ.
> + maxItems: 1
> +
> + clocks:
> + description: phandle to the clock connected on rtc clock line.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - spi-max-frequency
This should not be required.
> + - reg
> + - irq-gpios
> +
> +examples:
> + - |
> + spi1: spi@fc018000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cs-gpios = <&pioB 21 0>;
> + status = "okay";
> + wilc_spi@0 {
> + compatible = "microchip,wilc1000-spi";
> + spi-max-frequency = <48000000>;
> + reg = <0>;
> + irq-gpios = <&pioC 27 0>;
> + clocks = <&pck1>;
> + clock-names = "rtc_clk";
Not documented. '_clk' is redundant.
> + assigned-clocks = <&pck1>;
> + assigned-clock-rates = <32768>;
Not documented.
> + status = "okay";
> + };
> + };
> --
> 2.24.0
next prev parent reply other threads:[~2020-03-03 2:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 16:34 [PATCH v4 00/18] wilc1000: move out of staging Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 01/18] wilc1000: add hif.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 02/18] wilc1000: add hif.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 03/18] wilc1000: add wlan_if.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 04/18] wilc1000: add wlan_cfg.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 06/18] wilc1000: add cfg80211.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 05/18] wilc1000: add wlan_cfg.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 07/18] wilc1000: add cfg80211.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 09/18] wilc1000: add netdev.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 08/18] wilc1000: add netdev.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 10/18] wilc1000: add mon.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 12/18] wilc1000: add wlan.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 11/18] wilc1000: add spi.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 13/18] wilc1000: add wlan.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 14/18] wilc1000: add sdio.c Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 15/18] wilc1000: add fw.h Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 17/18] dt: bindings: net: add microchip,wilc1000,spi.yaml Ajay.Kathat
2020-03-03 2:02 ` Rob Herring [this message]
2020-03-03 12:45 ` Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 16/18] dt: bindings: net: add microchip,wilc1000,sdio.yaml Ajay.Kathat
2020-03-03 1:55 ` Rob Herring
2020-03-03 12:28 ` Ajay.Kathat
2020-03-02 16:34 ` [PATCH v4 18/18] wilc1000: add Makefile and Kconfig files for wilc1000 compilation Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303020230.GA15543@bogus \
--to=robh@kernel.org \
--cc=Adham.Abozaeid@microchip.com \
--cc=Ajay.Kathat@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Venkateswara.Kaja@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).