From: Rob Herring <robh@kernel.org>
To: Rakesh Pillai <pillair@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: ath10k: Add wifi-firmware subnode for wifi node
Date: Tue, 31 Mar 2020 15:40:51 -0600 [thread overview]
Message-ID: <20200331214051.GA2053@bogus> (raw)
In-Reply-To: <1585134100-5944-2-git-send-email-pillair@codeaurora.org>
On Wed, Mar 25, 2020 at 04:31:38PM +0530, Rakesh Pillai wrote:
> Add a wifi-firmware subnode for the wifi node.
> This wifi-firmware subnode is needed for the
> targets which do not support TrustZone.
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 71bf91f..65ee68e 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -96,6 +96,17 @@ Optional properties:
> - qcom,coexist-gpio-pin : gpio pin number information to support coex
> which will be used by wifi firmware.
>
> +* Subnodes
> +The ath10k wifi node can contain one optional firmware subnode.
> +Firmware subnode is needed when the platform does not have TustZone.
> +The firmware subnode must have:
> +
> +- iommus:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: A list of phandle and IOMMU specifier pairs.
> +
> +
> Example (to supply PCI based wifi block details):
>
> In this example, the node is defined as child node of the PCI controller.
> @@ -196,4 +207,7 @@ wifi@18000000 {
> memory-region = <&wifi_msa_mem>;
> iommus = <&apps_smmu 0x0040 0x1>;
> qcom,msa-fixed-perm;
> + wifi-firmware {
> + iommus = <&apps_iommu 0xc22 0x1>;
Why can't you just add a 2nd entry to the existing 'iommus' property?
A driver doing of_dma_configure() is generally not the right thing to
do.
Rob
next prev parent reply other threads:[~2020-03-31 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 11:01 [PATCH v2 0/3] Add support to handle targets without TrustZone Rakesh Pillai
2020-03-25 11:01 ` [PATCH v2 1/3] dt-bindings: ath10k: Add wifi-firmware subnode for wifi node Rakesh Pillai
2020-03-31 21:40 ` Rob Herring [this message]
2020-04-01 7:30 ` pillair
2020-03-25 11:01 ` [PATCH v2 2/3] ath10k: Setup the msa resources before qmi init Rakesh Pillai
2020-03-25 11:01 ` [PATCH v2 3/3] ath10k: Add support for targets without trustzone Rakesh Pillai
2020-04-15 17:33 ` pillair
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331214051.GA2053@bogus \
--to=robh@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).