From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA571C2BA1B for ; Mon, 6 Apr 2020 14:22:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C0D823D3B for ; Mon, 6 Apr 2020 14:22:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="XsWtQTHW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728680AbgDFOW1 (ORCPT ); Mon, 6 Apr 2020 10:22:27 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:53022 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728200AbgDFOW0 (ORCPT ); Mon, 6 Apr 2020 10:22:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586182946; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=2Vn7X1cSpiflRFN1VreX4R0Trwz919PTZIn7s9PwGt0=; b=XsWtQTHWskCSSOjc7/+TYlMYMUj5qVTY+r1X1wAD+52nlIumSLtb6M3XmKHi/EjaDPR4DYPN 2vkXhe0UCyMsIvOXQNDazFqNkTay7H/XL8UOvHPzJooSsCH0sfrNi8CTYC0xQQwv6tgV90DW xV74CZYmdRYZN+hQtgBHghMGfW4= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8b3b0f.7f31281d6618-smtp-out-n03; Mon, 06 Apr 2020 14:22:07 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CB6BFC43636; Mon, 6 Apr 2020 14:22:07 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 206BBC433F2; Mon, 6 Apr 2020 14:22:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 206BBC433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: fix compiler warnings without CONFIG_THERMAL From: Kalle Valo In-Reply-To: <20200403083414.31392-1-yuehaibing@huawei.com> References: <20200403083414.31392-1-yuehaibing@huawei.com> To: YueHaibing Cc: , , , , , , YueHaibing User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200406142207.CB6BFC43636@smtp.codeaurora.org> Date: Mon, 6 Apr 2020 14:22:07 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org YueHaibing wrote: > drivers/net/wireless/ath/ath11k/thermal.h:45:1: > warning: no return statement in function returning non-void [-Wreturn-type] > drivers/net/wireless/ath/ath11k/core.c:416:28: error: > passing argument 1 of 'ath11k_thermal_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types] > > Add missing return 0 in ath11k_thermal_set_throttling, > and fix ath11k_thermal_unregister param type. > > Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support") > Signed-off-by: YueHaibing Patch applied to wireless-drivers.git, thanks. c9be1a642a7b ath11k: fix compiler warnings without CONFIG_THERMAL -- https://patchwork.kernel.org/patch/11472105/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches