From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 v5.7 1/6] iwlwifi: pcie: actually release queue memory in TVQM
Date: Tue, 21 Apr 2020 12:40:02 +0000 (UTC) [thread overview]
Message-ID: <20200421124002.81361C43636@smtp.codeaurora.org> (raw)
In-Reply-To: <iwlwifi.20200417100405.f5f4c4193ec1.Id5feebc9b4318041913a9c89fc1378bb5454292c@changeid>
Luca Coelho <luca@coelho.fi> wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The iwl_trans_pcie_dyn_txq_free() function only releases the frames
> that may be left on the queue by calling iwl_pcie_gen2_txq_unmap(),
> but doesn't actually free the DMA ring or byte-count tables for the
> queue. This leads to pretty large memory leaks (at least before my
> queue size improvements), in particular in monitor/sniffer mode on
> channel hopping since this happens on every channel change.
>
> This was also now more evident after the move to a DMA pool for the
> byte count tables, showing messages such as
>
> BUG iwlwifi:bc (...): Objects remaining in iwlwifi:bc on __kmem_cache_shutdown()
>
> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=206811.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Fixes: 6b35ff91572f ("iwlwifi: pcie: introduce a000 TX queues management")
> Cc: stable@vger.kernel.org # v4.14+
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
6 patches applied to wireless-drivers.git, thanks.
b98b33d5560a iwlwifi: pcie: actually release queue memory in TVQM
290d5e495183 iwlwifi: mvm: beacon statistics shouldn't go backwards
d8d663970234 iwlwifi: pcie: indicate correct RB size to device
e5b72e3bc476 iwlwifi: mvm: limit maximum queue appropriately
38af8d5a90a8 iwlwifi: mvm: Do not declare support for ACK Enabled Aggregation
e6d419f94331 iwlwifi: mvm: fix inactive TID removal return value usage
--
https://patchwork.kernel.org/patch/11494275/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-21 12:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 7:08 [PATCH v2 v5.7 0/6] iwlwifi: fixes intended for v5.7 2020-04-03-2 Luca Coelho
2020-04-17 7:08 ` [PATCH v2 v5.7 1/6] iwlwifi: pcie: actually release queue memory in TVQM Luca Coelho
2020-04-21 12:40 ` Kalle Valo [this message]
2020-04-17 7:08 ` [PATCH v2 v5.7 2/6] iwlwifi: mvm: beacon statistics shouldn't go backwards Luca Coelho
2020-04-21 19:56 ` Sasha Levin
2020-04-21 20:13 ` Luca Coelho
2020-04-17 7:08 ` [PATCH v2 v5.7 3/6] iwlwifi: pcie: indicate correct RB size to device Luca Coelho
2020-04-17 7:08 ` [PATCH v2 v5.7 4/6] iwlwifi: mvm: limit maximum queue appropriately Luca Coelho
2020-04-21 19:56 ` Sasha Levin
2020-04-21 20:14 ` Luca Coelho
2020-04-17 7:08 ` [PATCH v2 v5.7 5/6] iwlwifi: mvm: Do not declare support for ACK Enabled Aggregation Luca Coelho
2020-04-21 19:56 ` Sasha Levin
2020-04-21 20:13 ` Luca Coelho
2020-04-21 20:55 ` Sasha Levin
2020-04-17 7:08 ` [PATCH v2 v5.7 6/6] iwlwifi: mvm: fix inactive TID removal return value usage Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421124002.81361C43636@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).