From: Wei Yongjun <weiyongjun1@huawei.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()
Date: Mon, 27 Apr 2020 10:44:03 +0000 [thread overview]
Message-ID: <20200427104403.14598-1-weiyongjun1@huawei.com> (raw)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/ath/ath11k/ahb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index e7e3e64c07aa..7d3d1cc6f39f 100644
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
}
mem = devm_ioremap_resource(&pdev->dev, mem_res);
- if (IS_ERR(mem)) {
- dev_err(&pdev->dev, "ioremap error\n");
+ if (IS_ERR(mem))
return PTR_ERR(mem);
- }
ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (ret) {
next reply other threads:[~2020-04-27 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 10:44 Wei Yongjun [this message]
2020-04-28 9:28 ` [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe() Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427104403.14598-1-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=ath11k@lists.infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).