* [PATCH 12/15] ath10k: use new module_firmware_crashed()
[not found] <20200509043552.8745-1-mcgrof@kernel.org>
@ 2020-05-09 4:35 ` Luis Chamberlain
2020-05-09 4:35 ` [PATCH 13/15] ath6kl: " Luis Chamberlain
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: Luis Chamberlain @ 2020-05-09 4:35 UTC (permalink / raw)
To: jeyu
Cc: akpm, arnd, rostedt, mingo, aquini, cai, dyoung, bhe, peterz,
tglx, gpiccoli, pmladek, tiwai, schlad, andriy.shevchenko,
keescook, daniel.vetter, will, mchehab+samsung, kvalo, davem,
netdev, linux-kernel, Luis Chamberlain, linux-wireless, ath10k
This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.
Using a taint flag allows us to annotate when this happens clearly.
Cc: linux-wireless@vger.kernel.org
Cc: ath10k@lists.infradead.org
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 ++
drivers/net/wireless/ath/ath10k/sdio.c | 2 ++
drivers/net/wireless/ath/ath10k/snoc.c | 1 +
3 files changed, 5 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 1d941d53fdc9..6bd0f3b518b9 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1767,6 +1767,7 @@ static void ath10k_pci_fw_dump_work(struct work_struct *work)
scnprintf(guid, sizeof(guid), "n/a");
ath10k_err(ar, "firmware crashed! (guid %s)\n", guid);
+ module_firmware_crashed();
ath10k_print_driver_info(ar);
ath10k_pci_dump_registers(ar, crash_data);
ath10k_ce_dump_registers(ar, crash_data);
@@ -2837,6 +2838,7 @@ static int ath10k_pci_hif_power_up(struct ath10k *ar,
if (ret) {
if (ath10k_pci_has_fw_crashed(ar)) {
ath10k_warn(ar, "firmware crashed during chip reset\n");
+ module_firmware_crashed();
ath10k_pci_fw_crashed_clear(ar);
ath10k_pci_fw_crashed_dump(ar);
}
diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c
index e2aff2254a40..d34ad289380f 100644
--- a/drivers/net/wireless/ath/ath10k/sdio.c
+++ b/drivers/net/wireless/ath/ath10k/sdio.c
@@ -794,6 +794,7 @@ static int ath10k_sdio_mbox_proc_dbg_intr(struct ath10k *ar)
/* TODO: Add firmware crash handling */
ath10k_warn(ar, "firmware crashed\n");
+ module_firmware_crashed();
/* read counter to clear the interrupt, the debug error interrupt is
* counter 0.
@@ -915,6 +916,7 @@ static int ath10k_sdio_mbox_proc_cpu_intr(struct ath10k *ar)
if (cpu_int_status & MBOX_CPU_STATUS_ENABLE_ASSERT_MASK) {
ath10k_err(ar, "firmware crashed!\n");
queue_work(ar->workqueue, &ar->restart_work);
+ module_firmware_crashed();
}
return ret;
}
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index 354d49b1cd45..7cfc123c345c 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -1451,6 +1451,7 @@ void ath10k_snoc_fw_crashed_dump(struct ath10k *ar)
scnprintf(guid, sizeof(guid), "n/a");
ath10k_err(ar, "firmware crashed! (guid %s)\n", guid);
+ module_firmware_crashed();
ath10k_print_driver_info(ar);
ath10k_msa_dump_memory(ar, crash_data);
mutex_unlock(&ar->dump_mutex);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 13/15] ath6kl: use new module_firmware_crashed()
[not found] <20200509043552.8745-1-mcgrof@kernel.org>
2020-05-09 4:35 ` [PATCH 12/15] ath10k: use new module_firmware_crashed() Luis Chamberlain
@ 2020-05-09 4:35 ` Luis Chamberlain
2020-05-09 4:35 ` [PATCH 14/15] brcm80211: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 15/15] mwl8k: " Luis Chamberlain
3 siblings, 0 replies; 4+ messages in thread
From: Luis Chamberlain @ 2020-05-09 4:35 UTC (permalink / raw)
To: jeyu
Cc: akpm, arnd, rostedt, mingo, aquini, cai, dyoung, bhe, peterz,
tglx, gpiccoli, pmladek, tiwai, schlad, andriy.shevchenko,
keescook, daniel.vetter, will, mchehab+samsung, kvalo, davem,
netdev, linux-kernel, Luis Chamberlain, linux-wireless, ath10k
This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.
Using a taint flag allows us to annotate when this happens clearly.
Cc: linux-wireless@vger.kernel.org
Cc: ath10k@lists.infradead.org
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/net/wireless/ath/ath6kl/hif.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c
index d1942537ea10..cfd838607544 100644
--- a/drivers/net/wireless/ath/ath6kl/hif.c
+++ b/drivers/net/wireless/ath/ath6kl/hif.c
@@ -120,6 +120,7 @@ static int ath6kl_hif_proc_dbg_intr(struct ath6kl_device *dev)
int ret;
ath6kl_warn("firmware crashed\n");
+ module_firmware_crashed();
/*
* read counter to clear the interrupt, the debug error interrupt is
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 14/15] brcm80211: use new module_firmware_crashed()
[not found] <20200509043552.8745-1-mcgrof@kernel.org>
2020-05-09 4:35 ` [PATCH 12/15] ath10k: use new module_firmware_crashed() Luis Chamberlain
2020-05-09 4:35 ` [PATCH 13/15] ath6kl: " Luis Chamberlain
@ 2020-05-09 4:35 ` Luis Chamberlain
2020-05-09 4:35 ` [PATCH 15/15] mwl8k: " Luis Chamberlain
3 siblings, 0 replies; 4+ messages in thread
From: Luis Chamberlain @ 2020-05-09 4:35 UTC (permalink / raw)
To: jeyu
Cc: akpm, arnd, rostedt, mingo, aquini, cai, dyoung, bhe, peterz,
tglx, gpiccoli, pmladek, tiwai, schlad, andriy.shevchenko,
keescook, daniel.vetter, will, mchehab+samsung, kvalo, davem,
netdev, linux-kernel, Luis Chamberlain, linux-wireless,
brcm80211-dev-list.pdl, brcm80211-dev-list, Arend van Spriel,
Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng,
Rafał Miłecki, Pieter-Paul Giesberts
This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.
Using a taint flag allows us to annotate when this happens clearly.
Cc: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: brcm80211-dev-list@cypress.com
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Franky Lin <franky.lin@broadcom.com>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>
Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: Wright Feng <wright.feng@cypress.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "Rafał Miłecki" <rafal@milecki.pl>
Cc: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
index c88655acc78c..d623f83568b3 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
@@ -1393,6 +1393,7 @@ void brcmf_fw_crashed(struct device *dev)
struct brcmf_pub *drvr = bus_if->drvr;
bphy_err(drvr, "Firmware has halted or crashed\n");
+ module_firmware_crashed();
brcmf_dev_coredump(dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 15/15] mwl8k: use new module_firmware_crashed()
[not found] <20200509043552.8745-1-mcgrof@kernel.org>
` (2 preceding siblings ...)
2020-05-09 4:35 ` [PATCH 14/15] brcm80211: " Luis Chamberlain
@ 2020-05-09 4:35 ` Luis Chamberlain
3 siblings, 0 replies; 4+ messages in thread
From: Luis Chamberlain @ 2020-05-09 4:35 UTC (permalink / raw)
To: jeyu
Cc: akpm, arnd, rostedt, mingo, aquini, cai, dyoung, bhe, peterz,
tglx, gpiccoli, pmladek, tiwai, schlad, andriy.shevchenko,
keescook, daniel.vetter, will, mchehab+samsung, kvalo, davem,
netdev, linux-kernel, Luis Chamberlain, linux-wireless,
Lennert Buytenhek, Gustavo A. R. Silva, Johannes Berg,
Ganapathi Bhat
This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.
Using a taint flag allows us to annotate when this happens clearly.
Cc: linux-wireless@vger.kernel.org
Cc: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Ganapathi Bhat <ganapathi.bhat@nxp.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
drivers/net/wireless/marvell/mwl8k.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
index 97f23f93f6e7..d609ef1bb879 100644
--- a/drivers/net/wireless/marvell/mwl8k.c
+++ b/drivers/net/wireless/marvell/mwl8k.c
@@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw)
* the firmware has crashed
*/
if (priv->hw_restart_in_progress) {
+ module_firmware_crashed();
if (priv->hw_restart_owner == current)
return 0;
else
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread