Re: [PATCH 8/8] mac80211: IBSS: send deauth when expiring inactive STAs

Re: [PATCH 8/8] mac80211: IBSS: send deauth when expiring inactive STAs

[linux-wireless]

I have good reason to believe that this patch is causing lockups on my machine.

This is because of what I believe to be a very unreliable PCIe connection to
my wireless adapter, which means that it has to be reconfigured regularly.

On kernels with this patch applied however, the kernel seems to get stuck in a
loop doing so, meanwhile spamming the journal with 'Failed
check-sdata-in-driver check' warnings at an astonishing rate.

By instructing the kernel to panic when it detects a hung task, I have been
able to obtain the following stack traces from the persistent store (ignore the
'Tainted' flag, that's just because I omitted a large number of identical
'Failed check-sdata-in-driver check' oopses before this final one):

[ 2227.321477] ------------[ cut here ]------------
[ 2227.321477] wlan0:  Failed check-sdata-in-driver check, flags: 0x0
[ 2227.321486] WARNING: CPU: 3 PID: 6972 at net/mac80211/driver-ops.h:17 drv_sta_state+0x241/0x3e0 [mac80211]
[ 2227.321486] Modules linked in: rfcomm af_packet ctr ccm algif_aead cbc des_generic libdes ecb bnep arc4 algif_skcipher cmac sha512_ssse3 sha512_generic msr md4 algif_hash af_alg nls_iso8859_1 nls_cp437 vfat fat joydev mousedev uvcvideo videobuf2_vmalloc snd_hda_codec_hdmi videobuf2_memops snd_hda_codec_realtek snd_hda_codec_generic videobuf2_v4l2 videobuf2_common btusb x86_pkg_temp_thermal intel_powerclamp coretemp btrtl btbcm iwlmvm crc32_pclmul dell_laptop ledtrig_audio ghash_clmulni_intel videodev dell_wmi btintel mc sparse_keymap mac80211 bluetooth i915 intel_wmi_thunderbolt libarc4 mei_hdcp mei_wdt iTCO_wdt lz4 watchdog dell_smm_hwmon dell_smbios dcdbas intel_rapl_msr ecdh_generic ecc crc16 dell_wmi_descriptor wmi_bmof aesni_intel ppdev cec libaes drm_kms_helper crypto_simd iwlwifi cryptd glue_helper drm intel_cstate intel_gtt e1000e agpgart deflate intel_uncore evdev input_leds efi_pstore tpm_tis pstore tpm_tis_core intel_rapl_perf i2c_algo_bit i2c_i801 snd_hda_intel cfg80211
[ 2227.321497]  fb_sys_fops led_class ptp efivars psmouse mac_hid snd_intel_dspcfg syscopyarea mei_me sysfillrect snd_hda_codec serio_raw sysimgblt snd_hda_core pps_core mei tpm snd_hwdep i2c_core processor_thermal_device 8250_pci intel_rapl_common intel_pch_thermal thermal battery rng_core wmi intel_soc_dts_iosf parport_pc parport video dell_smo8800 backlight int3400_thermal int3403_thermal intel_pmc_core int340x_thermal_zone acpi_thermal_rel acpi_pad ac dell_rbtn ip6table_nat rfkill button iptable_nat nf_nat zra xt_conntrack zsmalloc nf_conntrack nf_defrag_ipv4 ip6t_rpfilter ipt_rpfilter ip6table_raw iptable_raw xt_pkttype nf_log_ipv6 nf_log_ipv4 nf_log_common xt_LOG xt_tcpudp ip6table_filter ip6_tables iptable_filter sch_fq_codel snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd soundcore loop cpufreq_powersave tun tap macvlan bridge stp llc kvm_intel kvm irqbypass efivarfs ip_tables x_tables ipv6 nf_defrag_ipv6 crc_ccitt autofs4 poly1305_generic libpoly1305 poly1305_x86_64 chacha_generic
[ 2227.321510]  chacha_x86_64 libchacha bcachefs libcrc32c crc32c_generic zstd_compress xor lz4_compress zstd_decompress crc64 raid6_pq sd_mod t10_pi crc_t10dif crct10dif_generic ahci libahci libata rtsx_pci_sdmmc xhci_pci mmc_core scsi_mod xhci_hcd atkbd libps2 usbcore crct10dif_pclmul crct10dif_common rtsx_pci crc32c_intel usb_common rtc_cmos i8042 serio dm_mod
[ 2227.321516] CPU: 3 PID: 6972 Comm: kworker/3:2 Tainted: G        W         5.6.13 #1-NixOS
[ 2227.321517] Hardware name: Dell Inc. Latitude E5470/0C8FKJ, BIOS 1.19.3 08/20/2018
[ 2227.321520] Workqueue: events_freezable ieee80211_restart_work [mac80211]
[ 2227.321524] RIP: 0010:drv_sta_state+0x241/0x3e0 [mac80211]
[ 2227.321525] Code: 00 45 31 e4 e9 70 fe ff ff 48 8b 83 78 04 00 00 48 8d b3 98 04 00 00 48 c7 c7 d8 0c 40 c1 48 85 c0 48 0f 45 f0 e8 c1 08 8e ec <0f> 0b 41 bc fb ff ff ff e9 47 fe ff ff 65 8b 05 7b 4f c7 3e 89 c0
[ 2227.321526] RSP: 0018:ffffb1255eb43a88 EFLAGS: 00010282
[ 2227.321526] RAX: 0000000000000000 RBX: ffffa088030b28c0 RCX: 0000000000000007
[ 2227.321527] RDX: 0000000000000007 RSI: 0000000000000092 RDI: ffffa0886dd99980
[ 2227.321528] RBP: ffffa0880cdd07c0 R08: 00000000001ce0a4 R09: 0000000000000045
[ 2227.321528] R10: ffffb1255eb43938 R11: ffffb1255eb4393d R12: ffffa0880cdd07c0
[ 2227.321529] R13: 0000000000000004 R14: 0000000000000001 R15: 0000000000000003
[ 2227.321530] FS:  0000000000000000(0000) GS:ffffa0886dd80000(0000) knlGS:0000000000000000
[ 2227.321531] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 2227.321531] CR2: 00007fbf74e2d000 CR3: 000000064abca002 CR4: 00000000003606e0
[ 2227.321532] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 2227.321533] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 2227.321533] Call Trace:
[ 2227.321538]  sta_info_move_state+0x18f/0x2b0 [mac80211]
[ 2227.321542]  __sta_info_destroy_part2+0x28/0x150 [mac80211]
[ 2227.321546]  __sta_info_flush+0x123/0x180 [mac80211]
[ 2227.321552]  ieee80211_set_disassoc+0xba/0x5b0 [mac80211]
[ 2227.321557]  ieee80211_mgd_deauth.cold+0x4a/0x1c2 [mac80211]
[ 2227.321562]  cfg80211_mlme_deauth+0xb3/0x1d0 [cfg80211]
[ 2227.321563]  ? mpihelp_addmul_1+0x23/0xc0
[ 2227.321568]  cfg80211_disconnect+0x98/0x1e0 [cfg80211]
[ 2227.321572]  cfg80211_leave+0x27/0x40 [cfg80211]
[ 2227.321576]  cfg80211_netdev_notifier_call+0x171/0x4e0 [cfg80211]
[ 2227.321578]  notifier_call_chain+0x4c/0x70
[ 2227.321579]  __dev_close_many+0x5f/0x110
[ 2227.321581]  dev_close_many+0x81/0x130
[ 2227.321581] Kernel panic - not syncing: hung_task: blocked tasks
[ 2227.321583] CPU: 0 PID: 32 Comm: khungtaskd Tainted: G        W         5.6.13 #1-NixOS
[ 2227.321583] Hardware name: Dell Inc. Latitude E5470/0C8FKJ, BIOS 1.19.3 08/20/2018
[ 2227.321584] Call Trace:
[ 2227.321586]  dump_stack+0x66/0x90
[ 2227.321587]  panic+0x101/0x2d7
[ 2227.321589]  watchdog+0x2c4/0x440
[ 2227.321590]  dev_close.part.0+0x3e/0x70
[ 2227.321593]  cfg80211_shutdown_all_interfaces+0x71/0xd0 [cfg80211]
[ 2227.321599]  ieee80211_reconfig+0xa2/0x1480 [mac80211]
[ 2227.321600]  ? try_to_del_timer_sync+0x4f/0x80
[ 2227.321602]  kthread+0xfb/0x130
[ 2227.321603]  ? hungtask_pm_notify+0x40/0x40
[ 2227.321604]  ? kthread_park+0x90/0x90
[ 2227.321605]  ret_from_fork+0x35/0x40
[ 2227.321610]  ieee80211_restart_work+0xb7/0xe0 [mac80211]
[ 2227.321612]  process_one_work+0x1e4/0x390
[ 2227.321613]  worker_thread+0x4d/0x3f0
[ 2227.321615]  kthread+0xfb/0x130
[ 2227.321616]  ? process_one_work+0x390/0x390
[ 2227.321617]  ? kthread_park+0x90/0x90
[ 2227.321619]  ret_from_fork+0x35/0x40
[ 2227.321620] ---[ end trace f9f5d799afd5a59f ]---
[ 2227.321623] Kernel Offset: 0x2cc00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)

(No Subject)

[hyperfekt]

Subject: Re: [PATCH 8/8] mac80211: IBSS: send deauth when expiring inactive STAs

After running a kernel without the patch some more, I can say that that only
seems to reduce the frequency of the lockups, instead of eliminating them.

I don't really feel capable of debugging this on my own, but the last kernel
version this problem does not occur on is 5.3.

Re: (no subject)

[Dan Carpenter]

On 5/1/11, Dan Carpenter <error27@gmail.com> wrote:
> On 4/30/11, Naveen Singh <sningh@atheros.com> wrote:
>> --- a/drivers/staging/ath6kl/os/linux/cfg80211.c
>> +++ b/drivers/staging/ath6kl/os/linux/cfg80211.c
>> @@ -1455,6 +1455,11 @@ ar6k_cfg80211_init(struct device *dev)
>>      wdev->wiphy->cipher_suites = cipher_suites;
>>      wdev->wiphy->n_cipher_suites = ARRAY_SIZE(cipher_suites);
>>
>> +    /*Support the seprate keys for unicast and multicast packets
>> +     *This flag is needed because because nl80211 checks for this
>> +     *flag before calling cfg ops for setting the key.*/
>> +    wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_SEPARATE_DEFAULT_KEYS;
>> +
>
> No subject.  Comment style wrong.  Please read CodingStyle and resend.
>

Also your email address is wrong so my reply bounced.  (The 'n' and 's'
were transposed).

regards,
dan carpenter

Re: (no subject)

[Dan Carpenter]

On 4/30/11, Naveen Singh <sningh@atheros.com> wrote:
> --- a/drivers/staging/ath6kl/os/linux/cfg80211.c
> +++ b/drivers/staging/ath6kl/os/linux/cfg80211.c
> @@ -1455,6 +1455,11 @@ ar6k_cfg80211_init(struct device *dev)
>      wdev->wiphy->cipher_suites = cipher_suites;
>      wdev->wiphy->n_cipher_suites = ARRAY_SIZE(cipher_suites);
>
> +    /*Support the seprate keys for unicast and multicast packets
> +     *This flag is needed because because nl80211 checks for this
> +     *flag before calling cfg ops for setting the key.*/
> +    wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_SEPARATE_DEFAULT_KEYS;
> +

No subject.  Comment style wrong.  Please read CodingStyle and resend.

regards,
dan carpenter

(no subject)

[Cristian]

SUBSCRIBE LINUX-WIRELESS

(no subject)

[Glenn]

subscribe linux-wireless