From: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
To: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Double Lo <double.lo@cypress.com>,
Chi-hsien Lin <chi-hsien.lin@cypress.com>
Subject: [PATCH V2 5/6] brcmfmac: fix throughput zero stalls on PM 1 mode due to credit map
Date: Wed, 10 Jun 2020 10:21:05 -0500 [thread overview]
Message-ID: <20200610152106.175257-6-chi-hsien.lin@cypress.com> (raw)
In-Reply-To: <20200610152106.175257-1-chi-hsien.lin@cypress.com>
From: Double Lo <double.lo@cypress.com>
This patch move the credit map setting to right place to avoid
brcmf_fws_return_credits() return without setting the credit map.
It fix the thoughput zero stalls issue in softAP mode when STA
using PM 1 mode.
Signed-off-by: Double Lo <double.lo@cypress.com>
Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
index ce8c6ceafc58..ab4526223a93 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
@@ -1193,6 +1193,8 @@ static void brcmf_fws_return_credits(struct brcmf_fws_info *fws,
if (!credits)
return;
+ fws->fifo_credit_map |= 1 << fifo;
+
if (fifo > BRCMF_FWS_FIFO_AC_BK &&
fifo <= BRCMF_FWS_FIFO_AC_VO) {
for (lender_ac = BRCMF_FWS_FIFO_AC_VO; lender_ac >= 0;
@@ -1216,7 +1218,6 @@ static void brcmf_fws_return_credits(struct brcmf_fws_info *fws,
if (credits) {
fws->fifo_credit[fifo] += credits;
- fws->fifo_credit_map |= 1 << fifo;
}
if (fws->fifo_credit[fifo] > fws->init_fifo_credit[fifo])
--
2.25.0
next prev parent reply other threads:[~2020-06-10 15:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 15:21 [PATCH V2 0/6] brcmfmac: flow control and p2p fix series Chi-Hsien Lin
2020-06-10 15:21 ` [PATCH V2 1/6] brcmfmac: allow credit borrowing for all access categories Chi-Hsien Lin
2020-07-14 9:47 ` Kalle Valo
2020-06-10 15:21 ` [PATCH V2 2/6] brcmfmac: increase message buffer size for control packets Chi-Hsien Lin
2020-06-10 15:21 ` [PATCH V2 3/6] brcmfmac: reserve 2 credits for host tx control path Chi-Hsien Lin
2020-08-03 16:27 ` Dmitry Osipenko
2020-08-04 11:08 ` Kalle Valo
2020-08-04 15:53 ` Dmitry Osipenko
2020-08-04 17:22 ` Kalle Valo
2020-08-05 8:24 ` Chi-Hsien Lin
2020-08-05 14:01 ` Dmitry Osipenko
2020-08-11 8:35 ` Wright Feng
2020-08-11 14:54 ` Dmitry Osipenko
2020-08-12 4:03 ` Wright Feng
2020-08-12 14:22 ` Dmitry Osipenko
2020-08-13 3:03 ` Wright Feng
2020-08-13 21:30 ` Dmitry Osipenko
2020-06-10 15:21 ` [PATCH V2 4/6] brcmfmac: update tx status flags to sync with firmware Chi-Hsien Lin
2020-06-10 15:21 ` Chi-Hsien Lin [this message]
2020-06-10 15:21 ` [PATCH V2 6/6] brcmfmac: initialize the requested dwell time Chi-Hsien Lin
2020-06-22 15:04 ` Chi-Hsien Lin
2020-07-14 9:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610152106.175257-6-chi-hsien.lin@cypress.com \
--to=chi-hsien.lin@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=double.lo@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).