From: Bob Copeland <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: me@bcopeland.com, linux-wireless@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 7/9] wmediumd: add the ability to write a pcapng file
Date: Thu, 25 Jun 2020 23:10:06 -0400 [thread overview]
Message-ID: <20200626031006.GC14303@bobcopeland.com> (raw)
In-Reply-To: <20200625150754.554b7fc226a1.I14409b6cb5998e7bd087c1329952fbfa1a30d45e@changeid>
On Thu, Jun 25, 2020 at 03:08:42PM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Add the ability to write a pcapng file containing all the data.
> The radiotap header is currently very minimal with only the
> frequency and the signal strength.
> + if (!filename)
> + return;
> +
> + ctx->pcap_file = fopen(filename, "w+");
I know it doesn't actually matter, but would be nice to close this
somewhere.
--
Bob Copeland %% https://bobcopeland.com/
next prev parent reply other threads:[~2020-06-26 3:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 13:08 wmediumd: further updates Johannes Berg
2020-06-25 13:08 ` [PATCH 1/9] wmediumd: add -lstdc++ for SANITIZE=1 Johannes Berg
2020-06-25 13:08 ` [PATCH 2/9] wmediumd: properly wait for control socket ACK Johannes Berg
2020-06-25 13:08 ` [PATCH 3/9] wmediumd: sync with external scheduler on API socket Johannes Berg
2020-06-25 13:08 ` [PATCH 4/9] wmediumd: init time controller connection later Johannes Berg
2020-06-25 13:08 ` [PATCH 5/9] wmediumd: add a control message to the API socket Johannes Berg
2020-06-25 13:08 ` [PATCH 6/9] wmediumd: fix RX message with cookie Johannes Berg
2020-06-25 13:08 ` [PATCH 7/9] wmediumd: add the ability to write a pcapng file Johannes Berg
2020-06-26 3:10 ` Bob Copeland [this message]
2020-06-26 8:10 ` Johannes Berg
2020-06-25 13:08 ` [PATCH 8/9] wmediumd: lib: minor code cleanups Johannes Berg
2020-06-25 13:08 ` [PATCH 9/9] wmediumd: lib: wallclock: fix timerfd handling Johannes Berg
2020-06-26 3:10 ` wmediumd: further updates Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626031006.GC14303@bobcopeland.com \
--to=me@bobcopeland.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).