Re: [PATCH] ath11k: cold boot calibration support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3501 bytes --]

Hi Sowmiya,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ath6kl/ath-next]
[cannot apply to v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sowmiya-Sree-Elavalagan/ath11k-cold-boot-calibration-support/20200702-222828
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 003a086ffc0d1affbb8300b36225fb8150a2d40a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/ath/ath11k/ahb.c:641:5: warning: no previous prototype for function 'ath11k_ahb_fwreset_from_cold_boot' [-Wmissing-prototypes]
   int ath11k_ahb_fwreset_from_cold_boot(struct ath11k_base *ab)
       ^
   drivers/net/wireless/ath/ath11k/ahb.c:641:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int ath11k_ahb_fwreset_from_cold_boot(struct ath11k_base *ab)
   ^
   static 
   drivers/net/wireless/ath/ath11k/ahb.c:962:15: warning: cast to smaller integer type 'enum ath11k_hw_rev' from 'const void *' [-Wvoid-pointer-to-enum-cast]
           ab->hw_rev = (enum ath11k_hw_rev)of_id->data;
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.
--
>> drivers/net/wireless/ath/ath11k/qmi.c:2127:5: warning: no previous prototype for function 'ath11k_qmi_process_coldboot_calibration' [-Wmissing-prototypes]
   int ath11k_qmi_process_coldboot_calibration(struct ath11k_base *ab)
       ^
   drivers/net/wireless/ath/ath11k/qmi.c:2127:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int ath11k_qmi_process_coldboot_calibration(struct ath11k_base *ab)
   ^
   static 
   1 warning generated.

vim +/ath11k_ahb_fwreset_from_cold_boot +641 drivers/net/wireless/ath/ath11k/ahb.c

   640	
 > 641	int ath11k_ahb_fwreset_from_cold_boot(struct ath11k_base *ab)
   642	{
   643		int timeout;
   644	
   645		if (ath11k_cold_boot_cal == 0 || ab->qmi.cal_done)
   646			return 0;
   647	
   648		ath11k_dbg(ab, ATH11K_DBG_AHB, "wait for cold boot done\n");
   649		timeout = wait_event_timeout(ab->qmi.cold_boot_waitq,
   650					     (ab->qmi.cal_done  == 1),
   651					     ATH11K_COLD_BOOT_FW_RESET_DELAY);
   652		if (timeout <= 0) {
   653			ath11k_warn(ab, "Coldboot Calibration timed out\n");
   654			return -ETIMEDOUT;
   655		}
   656	
   657		/* reset the firmware */
   658		ath11k_ahb_power_down(ab);
   659		ath11k_ahb_power_up(ab);
   660	
   661		ath11k_dbg(ab, ATH11K_DBG_AHB, "exit wait for cold boot done\n");
   662		return 0;
   663	}
   664	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75332 bytes --]