Re: [PATCH] brcm80211: brcmsmac: Move LEDs to GPIO descriptors

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3690 bytes --]

Hi Linus,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master v5.8-rc4 next-20200706]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Linus-Walleij/brcm80211-brcmsmac-Move-LEDs-to-GPIO-descriptors/20200706-165145
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a378c0449507e00e96534ff9ce9034e185425182)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c:91:6: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
                             err);
                             ^~~
   include/net/cfg80211.h:7837:35: note: expanded from macro 'wiphy_err'
           dev_err(&(wiphy)->dev, format, ##args)
                                            ^~~~
   include/linux/dev_printk.h:104:32: note: expanded from macro 'dev_err'
           _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                         ^~~~~~~~~~~
   drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c:53:12: note: initialize the variable 'err' to silence this warning
           int i, err;
                     ^
                      = 0
   1 warning generated.

vim +/err +91 drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c

    50	
    51	int brcms_led_register(struct brcms_info *wl)
    52	{
    53		int i, err;
    54		struct brcms_led *radio_led = &wl->radio_led;
    55		/* get CC core */
    56		struct bcma_drv_cc *cc_drv  = &wl->wlc->hw->d11core->bus->drv_cc;
    57		struct gpio_chip *bcma_gpio = &cc_drv->gpio;
    58		struct ssb_sprom *sprom = &wl->wlc->hw->d11core->bus->sprom;
    59		u8 *leds[] = { &sprom->gpio0,
    60			&sprom->gpio1,
    61			&sprom->gpio2,
    62			&sprom->gpio3 };
    63		int hwnum = -1;
    64		enum gpio_lookup_flags lflags = GPIO_ACTIVE_HIGH;
    65	
    66		if (!bcma_gpio || !gpio_is_valid(bcma_gpio->base))
    67			return -ENODEV;
    68	
    69		/* find radio enabled LED */
    70		for (i = 0; i < BRCMS_LED_NO; i++) {
    71			u8 led = *leds[i];
    72			if ((led & BRCMS_LED_BEH_MASK) == BRCMS_LED_RADIO) {
    73				hwnum = i;
    74				if (led & BRCMS_LED_AL_MASK)
    75					lflags = GPIO_ACTIVE_LOW;
    76				break;
    77			}
    78		}
    79	
    80		/* No LED, bail out */
    81		if (hwnum == -1)
    82			return -ENODEV;
    83	
    84		/* Try to obtain this LED GPIO line */
    85		radio_led->gpiod = gpiochip_request_own_desc(bcma_gpio, hwnum,
    86							     "radio on", lflags,
    87							     GPIOD_OUT_LOW);
    88	
    89		if (IS_ERR(radio_led->gpiod)) {
    90			wiphy_err(wl->wiphy, "requesting led GPIO failed (err: %d)\n",
  > 91				  err);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75293 bytes --]