From: Kalle Valo <kvalo@codeaurora.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Jakub Kicinski <kuba@kernel.org>,
"Tzu-En Huang" <tehuang@realtek.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH -next] rtw88: 8821c: make symbol 'rtw8821c_rtw_pwr_track_tbl' static
Date: Sun, 2 Aug 2020 15:06:25 +0000 (UTC) [thread overview]
Message-ID: <20200802150625.E78CDC43391@smtp.codeaurora.org> (raw)
In-Reply-To: <20200721134901.33968-1-weiyongjun1@huawei.com>
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> The sparse tool complains as follows:
>
> drivers/net/wireless/realtek/rtw88/rtw8821c.c:1374:32: warning:
> symbol 'rtw8821c_rtw_pwr_track_tbl' was not declared. Should it be static?
>
> This variable is not used outside of rtw8821c.c, so this commit
> marks it static.
>
> Fixes: 3a4312828ce1 ("rtw88: 8821c: add power tracking")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
9de6959f8584 rtw88: 8821c: make symbol 'rtw8821c_rtw_pwr_track_tbl' static
--
https://patchwork.kernel.org/patch/11675705/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-08-02 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 13:49 [PATCH -next] rtw88: 8821c: make symbol 'rtw8821c_rtw_pwr_track_tbl' static Wei Yongjun
2020-08-02 15:06 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200802150625.E78CDC43391@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=hulkci@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tehuang@realtek.com \
--cc=weiyongjun1@huawei.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).