From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B214C433E4 for ; Fri, 14 Aug 2020 16:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AE1520791 for ; Fri, 14 Aug 2020 16:38:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KFwZiGgG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728002AbgHNQih (ORCPT ); Fri, 14 Aug 2020 12:38:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726754AbgHNQig (ORCPT ); Fri, 14 Aug 2020 12:38:36 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF036C061386 for ; Fri, 14 Aug 2020 09:38:35 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id k20so8434713wmi.5 for ; Fri, 14 Aug 2020 09:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=SBRnLFjikbgUE3zhul5CZPoOJXI826l4dDRWqFfAQRw=; b=KFwZiGgGsHOEQTkED76nmBtiNDbHKD6KDhybIgSAGbZvZJg0xNdODvEI53hyV7GVQq fv6hqAIMlvAzZZ/H+0svImJXztuW8n+06vvlckdkmKFvtA30QhP8xutcoXJqrxq0GxXk 1b5uZAP095ez+KqvWry9UQgjiMeVB4IZkisACV1h9qlAVFN59iLGEeuij5V7ciNXqLrR DAHbNYpEOpitJZR4USDa+8UbITYPbhO6VHr6Rvfmo8CEKofCfAyITHcfBbrxc2szZznV FGGP9j5NnYrV6b8JVilkN+og4BUDJJIFUNq1WvIqeKb8lPc+kwlIO3BQdDraGHhz5SQL 0UTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=SBRnLFjikbgUE3zhul5CZPoOJXI826l4dDRWqFfAQRw=; b=gJ2CDWWzg32NXuRKqwIIToYTAvSRzNiPQQqc6zvGUGgdOuyay5TAyZP9ZkMCNFrw/V TJmIunNGr+9EzA57TvSkVFtcLd6p4iz67lclL2P9C26XOPCqCJ8wiFAcT9W7n7bGdpiD 6zPpHAT9wkeVWRrGpNj1QF3Br77vaORuWv9a1uOvpxN1T7l4kdSXA58s3qf5ABY2HGpw mhTw86Xqrhr4oTuF8RDm8DE9JXgI5nQ5rfIQF6ou2JHLnguN5ulP9fZ2LlJcA+mSTnhq kWsWPTsC34RANfmX5WI+9WGJEQcFHYzQz7vmXV3DYPNyaCZlKA0c51yRei+1n61L7ImV DBCQ== X-Gm-Message-State: AOAM533hvLYhFseIVssYh7bvWd9wef+WLFKUK+E5OF4o5KK5+kNItHEu F6FYWtrso4FazMiHduM5HDGmDw== X-Google-Smtp-Source: ABdhPJzibn0jjmtjzLY2ilhQ9fx+rMUtqgQREpZcOlyPu6KoHh7sYeqxx1ZLF1RbiozQAYxr3iNwGQ== X-Received: by 2002:a1c:3285:: with SMTP id y127mr3273780wmy.104.1597423114464; Fri, 14 Aug 2020 09:38:34 -0700 (PDT) Received: from dell ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id r22sm16053717wmh.45.2020.08.14.09.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 09:38:33 -0700 (PDT) Date: Fri, 14 Aug 2020 17:38:31 +0100 From: Lee Jones To: Kalle Valo Cc: davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, Benjamin Reed , Javier Achirica , Jean Tourrilhes , Fabrice Bellet , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues Message-ID: <20200814163831.GN4354@dell> References: <20200814113933.1903438-1-lee.jones@linaro.org> <20200814113933.1903438-13-lee.jones@linaro.org> <87r1s9l0mc.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87r1s9l0mc.fsf@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 14 Aug 2020, Kalle Valo wrote: > Lee Jones writes: > > > - Ensure spaces appear after {for, if, while, etc} > > - Ensure spaces to not appear after '(' > > - Ensure spaces to not appear before ')' > > - Ensure spaces appear between ')' and '{' > > - Ensure spaces appear after ',' > > - Ensure spaces do not appear before ',' > > - Ensure spaces appear either side of '=' > > - Ensure '{'s which open functions are on a new line > > - Remove trailing whitespace > > > > There are still a whole host of issues with this file, but this > > patch certainly breaks the back of them. > > > > Cc: Kalle Valo > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: Benjamin Reed > > Cc: Javier Achirica > > Cc: Jean Tourrilhes > > Cc: Fabrice Bellet > > Cc: linux-wireless@vger.kernel.org > > Cc: netdev@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/net/wireless/cisco/airo.c | 897 ++++++++++++++++-------------- > > 1 file changed, 467 insertions(+), 430 deletions(-) > > This is a driver for ancient hardware, I'm not sure if it's worth trying > to fix any style issues. Is anyone even using it? Should we instead just > remove the driver? Sounds like a reasonable solution to me. I'm also happy to do it, if there are no objections. As it stands, it's polluting the code-base and the build-log, so something should be done. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog