From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5EDC433DF for ; Fri, 14 Aug 2020 16:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 351A520829 for ; Fri, 14 Aug 2020 16:43:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qHm26J+I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726897AbgHNQn2 (ORCPT ); Fri, 14 Aug 2020 12:43:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726641AbgHNQn0 (ORCPT ); Fri, 14 Aug 2020 12:43:26 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54FC5C061384 for ; Fri, 14 Aug 2020 09:43:26 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id g8so7993434wmk.3 for ; Fri, 14 Aug 2020 09:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=bw1Tir57DBh//uKbJmgY59q5qNNSVFGXpIBJzyrS4Lw=; b=qHm26J+IwYUn5IJa2ysdzXpsHxc1KAt6rMFUFONUIDMIASRMSgivr98FjRGVhasvPQ WOuffJNjFYuiO6PKizYbOKXKKNTHX5MrodACxfE93iH8gBsWtSvbMOKl16t3ArUkHyLT mRKQgeWXiL1b0FE+8ST0nanOd9slb1k0HMgBryQWBktVC8lHcWezaXAyAZfE2ZRaph4Z LPRj51ijyosSxSA7AAO8QZGKG7/oJyUchYsshMvm96tI0sVntS5LDM9bhfKAwsK7gbCA CUa+Vw9/IPMPePnJKd6rzUbQSEXow1zb2E9HUKZrTSagHrfeUU2nhE2CiCP7CjLZ1GcI fasw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=bw1Tir57DBh//uKbJmgY59q5qNNSVFGXpIBJzyrS4Lw=; b=Tevu6ztNssQr4JkfQTT6KdbfxBujysx5P9M2KFiozArLpojgkUlDb6Wab9lhqh0+1V ntLUJmNgiJQmkfXeB83i1VnnMAz96tkj4a+MuoMzs8csbxF33tHLWFyRaWneAo2y5NBZ t4RtEFbB0UHGizAWJBrgcbNx7iKJhRx6vKlDLJ0dFLtRV1/6HseLs7ThbYPhMUSb+Cmb 5kTiBxdHMUq2Zzz0sFNkO32dFBv/13O7Gvrr5Tuzr9uWFxHLMg6XuQTVbKWCfkU1Xcym zuD97ylpPXZrxJmLLOHBm9ia3OUPT6/B4SlgQVY71O3bp6Y/P9dv/9W8FfsbKtOg4nYF sj1Q== X-Gm-Message-State: AOAM533lr7o8UdSUM0PR7NCAGWSaPMrlOZc6c7HRbYzwQhdGdler73uE cvdoiXM8Ws2BKE9TFrmVqAPhaQ== X-Google-Smtp-Source: ABdhPJwmidNzTZJLo6FoNt59fQ9wCqrOkTh1OvEDHY3GA0jq3pvnnNCUEsTLO6WWNVnFhJIs0j0Vxw== X-Received: by 2002:a7b:c7d5:: with SMTP id z21mr3391788wmk.145.1597423405005; Fri, 14 Aug 2020 09:43:25 -0700 (PDT) Received: from dell ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id d11sm17098148wrw.77.2020.08.14.09.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 09:43:24 -0700 (PDT) Date: Fri, 14 Aug 2020 17:43:22 +0100 From: Lee Jones To: Kalle Valo Cc: davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, Martin Langer , Stefano Brivio , Michael Buesch , van Dyk , Andreas Jaggi , Albert Herranz , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements Message-ID: <20200814164322.GP4354@dell> References: <20200814113933.1903438-1-lee.jones@linaro.org> <20200814113933.1903438-8-lee.jones@linaro.org> <87v9hll0ro.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87v9hll0ro.fsf@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 14 Aug 2020, Kalle Valo wrote: > Lee Jones writes: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_dummy_transmission’: > > drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > > drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_do_interrupt_thread’: > > drivers/net/wireless/broadcom/b43/main.c:2017:3: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > > > > Cc: Kalle Valo > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: Martin Langer > > Cc: Stefano Brivio > > Cc: Michael Buesch > > Cc: van Dyk > > Cc: Andreas Jaggi > > Cc: Albert Herranz > > Cc: linux-wireless@vger.kernel.org > > Cc: b43-dev@lists.infradead.org > > Cc: netdev@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/net/wireless/broadcom/b43/main.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > Please don't copy the full directory structure to the title. I'll change > the title to more simple version: > > b43: add braces around empty statements This seems to go the other way. "net: wireless: b43" seems sensible. > I'll do similar changes to other wireless-drivers patches. Thanks. Does that mean it's been applied, or is this future tense? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog