From: Kalle Valo <kvalo@codeaurora.org>
To: Tamizh Chelvam <tamizhr@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Tamizh Chelvam <tamizhr@codeaurora.org>
Subject: Re: [PATCHv2 3/4] ath10k: Add new api to support TID specific configuration
Date: Mon, 17 Aug 2020 14:19:34 +0000 (UTC) [thread overview]
Message-ID: <20200817141934.A251FC43387@smtp.codeaurora.org> (raw)
In-Reply-To: <1593875614-5683-4-git-send-email-tamizhr@codeaurora.org>
Tamizh Chelvam <tamizhr@codeaurora.org> wrote:
> This patch add ops for set_tid_config to support TID
> specific configuration. Station specific TID configuration
> will have more priority than vif specific TID configuration.
> WMI_SERVICE_PEER_TID_CONFIGS_SUPPORT service flag introduced
> to notify host for TID config support. And RTS_CTS extended tid
> configuration support advertised through the service flag
> WMI_10_4_SERVICE_EXT_PEER_TID_CONFIGS_SUPPORT.
>
> TID specific noack configuration requires
> aggregation should be disabled and rate for the data TID packets
> should be basic rates. So, if the TID already configured
> with noack policy then driver will ignore the aggregation
> or TX rate related configuration for the same data TID.
>
> In TX rate configuration should be applied with highest
> preamble configuration(HT rates should not be applied
> for the station which supports vht rates).
>
> Tested-on: QCA9984 hw1.0 PCI 10.4-3.9.0.2-00021
>
> Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
There few checkpatch warnings which I fixed and also I did some whitespace
changes to improve readability. Others were trivial but please check carefully
this change and let me know if it's ok:
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -7089,6 +7089,7 @@ static void ath10k_sta_tid_cfg_wk(struct work_struct *wk)
bool config_apply;
int ret, i;
u32 changed;
+ u8 nss;
arsta = container_of(wk, struct ath10k_sta, tid_config_wk);
sta = container_of((void *)arsta, struct ieee80211_sta, drv_priv);
@@ -7138,9 +7139,12 @@ static void ath10k_sta_tid_cfg_wk(struct work_struct *wk)
if (changed & (BIT(NL80211_TID_CONFIG_ATTR_TX_RATE) |
BIT(NL80211_TID_CONFIG_ATTR_TX_RATE_TYPE))) {
- if (arvif->rate_ctrl[i] > WMI_TID_CONFIG_RATE_CONTROL_AUTO &&
- ath10k_mac_validate_rate_mask(ar, sta, arvif->rate_code[i],
- ATH10K_HW_NSS(arvif->rate_code[i]))) {
+ nss = ATH10K_HW_NSS(arvif->rate_code[i]);
+ ret = ath10k_mac_validate_rate_mask(ar, sta,
+ arvif->rate_code[i],
+ nss);
+ if (ret &&
+ arvif->rate_ctrl[i] > WMI_TID_CONFIG_RATE_CONTROL_AUTO) {
arg.rate_ctrl = 0;
arg.rcode_flags = 0;
}
--
https://patchwork.kernel.org/patch/11643787/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-17 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 15:13 [PATCHv2 0/4] ath10k: Add support for TID specific configuration Tamizh Chelvam
2020-07-04 15:13 ` [PATCHv2 1/4] ath10k: Add wmi command support for station specific TID config Tamizh Chelvam
2020-08-26 14:53 ` Kalle Valo
2020-07-04 15:13 ` [PATCHv2 2/4] ath10k: Move rate mask validation function up in the file Tamizh Chelvam
2020-07-04 15:13 ` [PATCHv2 3/4] ath10k: Add new api to support TID specific configuration Tamizh Chelvam
2020-08-17 14:19 ` Kalle Valo [this message]
[not found] ` <20200817141934.733A0C433CB@smtp.codeaurora.org>
2020-08-18 10:06 ` Tamizh Chelvam
2020-07-04 15:13 ` [PATCHv2 4/4] ath10k: Add new api to support reset TID config Tamizh Chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817141934.A251FC43387@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).