From: Kalle Valo <kvalo@codeaurora.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: amitkarwar@gmail.com, ganapathi.bhat@nxp.com,
huxinming820@gmail.com, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] mwifiex: Clean up some err and dbg messages
Date: Thu, 27 Aug 2020 09:59:08 +0000 (UTC) [thread overview]
Message-ID: <20200827095908.630E9C433A1@smtp.codeaurora.org> (raw)
In-Reply-To: <20200819071853.113185-1-christophe.jaillet@wanadoo.fr>
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> The error message if 'pci_set_consistent_dma_mask()' fails is misleading.
> The function call uses 32 bits, but the error message reports 64.
>
> Moreover, according to the comment above 'dma_set_mask_and_coherent()'
> definition, such an error can never happen.
>
> So, simplify code, axe the misleading message and use
> 'dma_set_mask_and_coherent()' instead of 'dma_set_mask()' +
> 'dma_set_coherent_mask()'
>
> While at it, make some clean-up:
> - add # when reporting allocated length to be consistent between
> functions
> - s/consistent/coherent/
> - s/unsigned int/u32/ to be consistent between functions
> - align some code
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Patch applied to wireless-drivers-next.git, thanks.
5f8a3ed38bec mwifiex: Clean up some err and dbg messages
--
https://patchwork.kernel.org/patch/11723131/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-08-27 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 7:18 [PATCH] mwifiex: Clean up some err and dbg messages Christophe JAILLET
2020-08-27 9:59 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827095908.630E9C433A1@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).